Skip to content

Commit eb70674

Browse files
akulabs8asishupadhyay
andauthored
[improve] Slack connector options (#8738)
Co-authored-by: asishupadhyay <akulabs8@gmail.com>
1 parent 2a34ad0 commit eb70674

File tree

5 files changed

+11
-12
lines changed

5 files changed

+11
-12
lines changed

seatunnel-ci-tools/src/test/java/org/apache/seatunnel/api/ConnectorOptionCheckTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,6 @@ private Set<String> buildWhiteList() {
180180
whiteList.add("SlsSinkOptions");
181181
whiteList.add("DingTalkSinkOptions");
182182
whiteList.add("Neo4jSinkOptions");
183-
whiteList.add("SlackSinkOptions");
184183
whiteList.add("MaxcomputeSinkOptions");
185184
whiteList.add("PaimonSinkOptions");
186185
whiteList.add("TDengineSourceOptions");

seatunnel-connectors-v2/connector-slack/src/main/java/org/apache/seatunnel/connectors/seatunnel/slack/client/SlackClient.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@
3434
import java.io.IOException;
3535
import java.util.List;
3636

37-
import static org.apache.seatunnel.connectors.seatunnel.slack.config.SlackConfig.OAUTH_TOKEN;
38-
import static org.apache.seatunnel.connectors.seatunnel.slack.config.SlackConfig.SLACK_CHANNEL;
37+
import static org.apache.seatunnel.connectors.seatunnel.slack.config.SlackSinkOptions.OAUTH_TOKEN;
38+
import static org.apache.seatunnel.connectors.seatunnel.slack.config.SlackSinkOptions.SLACK_CHANNEL;
3939

4040
@Slf4j
4141
public class SlackClient {
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
import java.io.Serializable;
2626

2727
@Data
28-
public class SlackConfig implements Serializable {
28+
public class SlackSinkOptions implements Serializable {
2929

3030
public static final Option<String> WEBHOOKS_URL =
3131
Options.key("webhooks_url")

seatunnel-connectors-v2/connector-slack/src/main/java/org/apache/seatunnel/connectors/seatunnel/slack/sink/SlackSink.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
import org.apache.seatunnel.common.constants.PluginType;
3232
import org.apache.seatunnel.connectors.seatunnel.common.sink.AbstractSimpleSink;
3333
import org.apache.seatunnel.connectors.seatunnel.common.sink.AbstractSinkWriter;
34-
import org.apache.seatunnel.connectors.seatunnel.slack.config.SlackConfig;
34+
import org.apache.seatunnel.connectors.seatunnel.slack.config.SlackSinkOptions;
3535
import org.apache.seatunnel.connectors.seatunnel.slack.exception.SlackConnectorException;
3636

3737
import com.google.auto.service.AutoService;
@@ -67,9 +67,9 @@ public void prepare(Config pluginConfig) throws PrepareFailException {
6767
CheckResult checkResult =
6868
CheckConfigUtil.checkAllExists(
6969
pluginConfig,
70-
SlackConfig.WEBHOOKS_URL.key(),
71-
SlackConfig.OAUTH_TOKEN.key(),
72-
SlackConfig.SLACK_CHANNEL.key());
70+
SlackSinkOptions.WEBHOOKS_URL.key(),
71+
SlackSinkOptions.OAUTH_TOKEN.key(),
72+
SlackSinkOptions.SLACK_CHANNEL.key());
7373
if (!checkResult.isSuccess()) {
7474
throw new SlackConnectorException(
7575
SeaTunnelAPIErrorCode.CONFIG_VALIDATION_FAILED,

seatunnel-connectors-v2/connector-slack/src/main/java/org/apache/seatunnel/connectors/seatunnel/slack/sink/SlackSinkFactory.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
import org.apache.seatunnel.api.configuration.util.OptionRule;
2121
import org.apache.seatunnel.api.table.factory.Factory;
2222
import org.apache.seatunnel.api.table.factory.TableSinkFactory;
23-
import org.apache.seatunnel.connectors.seatunnel.slack.config.SlackConfig;
23+
import org.apache.seatunnel.connectors.seatunnel.slack.config.SlackSinkOptions;
2424

2525
import com.google.auto.service.AutoService;
2626

@@ -35,9 +35,9 @@ public String factoryIdentifier() {
3535
public OptionRule optionRule() {
3636
return OptionRule.builder()
3737
.required(
38-
SlackConfig.WEBHOOKS_URL,
39-
SlackConfig.OAUTH_TOKEN,
40-
SlackConfig.SLACK_CHANNEL)
38+
SlackSinkOptions.WEBHOOKS_URL,
39+
SlackSinkOptions.OAUTH_TOKEN,
40+
SlackSinkOptions.SLACK_CHANNEL)
4141
.build();
4242
}
4343
}

0 commit comments

Comments
 (0)