-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG][Connector-V2][http] fix httpheader cover #5446
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
+1
Hi, could you add some test case in a follow up PR? To make sure the http request created by SeaTunnel always set right header and avoid regression. Also we can know what's behavior now easiler. |
ok i will imporve e2e test for cover this case |
#5368
HttpClientProvider if set param config will addbody will overwrite httpheader application/json Causing parameter loss
So the modification to 'param' and 'body' can only take effect one at a time
Check list
New License Guide
release-note
.