Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][Connector-V2][http] fix httpheader cover #5446

Merged
merged 3 commits into from
Sep 11, 2023

Conversation

jackyyyyyssss
Copy link
Contributor

#5368
HttpClientProvider if set param config will addbody will overwrite httpheader application/json Causing parameter loss
So the modification to 'param' and 'body' can only take effect one at a time

Check list

@jackyyyyyssss jackyyyyyssss changed the title [BUF][Connector-V2][http] fix httpheader cover [BUG][Connector-V2][http] fix httpheader cover Sep 8, 2023
Copy link
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
+1

@EricJoy2048 EricJoy2048 merged commit cdd8e0a into apache:dev Sep 11, 2023
41 checks passed
Zhouwen-CN pushed a commit to Zhouwen-CN/seatunnel that referenced this pull request Sep 11, 2023
Zhouwen-CN pushed a commit to Zhouwen-CN/seatunnel that referenced this pull request Sep 11, 2023
@Hisoka-X
Copy link
Member

Hisoka-X commented Sep 12, 2023

Hi, could you add some test case in a follow up PR? To make sure the http request created by SeaTunnel always set right header and avoid regression. Also we can know what's behavior now easiler.

@jackyyyyyssss
Copy link
Contributor Author

Hi, could you add some test case in a follow up PR? To make sure the http request created by SeaTunnel always set right header and avoid regression. Also we can know what's behavior now easiler.

ok i will imporve e2e test for cover this case

gnehil pushed a commit to gnehil/seatunnel that referenced this pull request Oct 12, 2023
jackyyyyyssss pushed a commit to jackyyyyyssss/seatunnel that referenced this pull request Oct 18, 2023
@jackyyyyyssss jackyyyyyssss deleted the fix-httpheader branch July 23, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants