Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][connector-assert]support 'DECIMAL' type and fix 'Number' type precision issue #5479

Merged
merged 3 commits into from
Sep 14, 2023

Conversation

NickCodeJourney
Copy link
Contributor

when I use float type data test
https://user-images.githubusercontent.com/72905543/267356692-616eed7f-3ede-4ca9-bdaa-f18f4a496ee6.png

Purpose of this pull request

Check list

EricJoy2048
EricJoy2048 previously approved these changes Sep 13, 2023
hailin0
hailin0 previously approved these changes Sep 13, 2023
@hailin0 hailin0 self-requested a review September 13, 2023 13:30
@hailin0 hailin0 dismissed their stale review September 13, 2023 13:31

waiting for ci check

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hailin0 hailin0 merged commit d308e27 into apache:dev Sep 14, 2023
56 checks passed
@NickCodeJourney NickCodeJourney deleted the aseetsink branch September 14, 2023 15:41
gnehil pushed a commit to gnehil/seatunnel that referenced this pull request Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants