Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][doc][Connector-V2][SqlServer] Add SqlServer connector documentation #5498

Merged
merged 12 commits into from
Nov 8, 2023

Conversation

zhilinli123
Copy link
Contributor

@zhilinli123 zhilinli123 commented Sep 15, 2023

Purpose of this pull request

Check list

Comment on lines +157 to +169
Jdbc {
driver = com.microsoft.sqlserver.jdbc.SQLServerDriver
url = "jdbc:sqlserver://localhost:1433;databaseName=column_type_test"
user = SA
password = "Y.sa123456"
query = "insert into full_types_jdbc_sink( id, val_char, val_varchar, val_text, val_nchar, val_nvarchar, val_ntext, val_decimal, val_numeric, val_float, val_real, val_smallmoney, val_money, val_bit, val_tinyint, val_smallint, val_int, val_bigint, val_date, val_time, val_datetime2, val_datetime, val_smalldatetime ) values( ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? )"
is_exactly_once = "true"

xa_data_source_class_name = "com.microsoft.sqlserver.jdbc.SQLServerXADataSource"

} # If you would like to get more information about how to configure seatunnel and see full list of sink plugins,
# please go to https://seatunnel.apache.org/docs/connector-v2/sink/Jdbc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL: @ic4y @hailin0 I don't know whether the configuration is correct here. Please help me review thks

@ruanwenjun ruanwenjun changed the title [Feature][doc][Connector-V2][SqlServer] Add SqlServer connector document [Feature][doc][Connector-V2][SqlServer] Add SqlServer connector documentation Sep 15, 2023
@ruanwenjun ruanwenjun added the chore Chores about the project, like code cleaning up, typos, upgrading dependencies, etc. label Sep 15, 2023
@@ -2,12 +2,16 @@

> SqlServer CDC source connector

## Description
## Support Mysql Version
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mysql?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for my question

CREATE DATABASE column_type_test;

USE column_type_test;
EXEC sys.sp_cdc_enable_db;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be unique steps on how to enable CDC instead of in the task example

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Includes: cdc account creation, permission assignment, database/table configuration、verification

reference
https://github.com/apache/seatunnel/blob/dev/docs/en/connector-v2/source/MySQL-CDC.md#database-dependency

@@ -1,13 +1,17 @@
# SqlServer CDC
# SQL Server CDC
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An important content has been missed. How can I start SQL Server's CDC?

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

> EXEC xp_servicecontrol N'querystate', N'SQLServerAGENT'; <br/>
> If the result is running, prove that it is enabled. Otherwise, you need to manually enable it

2.Enable the CDC Agent
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
2.Enable the CDC Agent
2. Enable the CDC Agent

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I didn't see this comment and merged ~

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will revise it. Thank you for your review
@ruanwenjun @hailin0

@ruanwenjun ruanwenjun merged commit ebc054b into apache:dev Nov 8, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved chore Chores about the project, like code cleaning up, typos, upgrading dependencies, etc. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants