Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix] Ensure install-plugin.sh compatibility with sh on Debian #5630 #5631

Merged

Conversation

yanxiaole
Copy link
Contributor

Purpose of this pull request

This PR remedies the "Bad substitution" error encountered when executing install-plugin.sh under dash on Debian systems.
Fixes #5630

Does this PR introduce any user-facing change?

No

How was this patch tested?

manually run sh bin/install-plugin.sh 2.3.3

Check list

@Hisoka-X Hisoka-X added this to the 2.3.4 milestone Oct 16, 2023
@Hisoka-X
Copy link
Member

Cool! Could you open CI in your fork repository?

@yanxiaole
Copy link
Contributor Author

Cool! Could you open CI in your fork repository?

enabled, how can I trigger it?

@Hisoka-X
Copy link
Member

Cool! Could you open CI in your fork repository?

enabled, how can I trigger it?

add some empty commit

@yanxiaole
Copy link
Contributor Author

Cool! Could you open CI in your fork repository?

enabled, how can I trigger it?

add some empty commit

done

@Hisoka-X
Copy link
Member

cc @EricJoy2048

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yanxiaole .

@EricJoy2048 EricJoy2048 merged commit 62eb82d into apache:dev Oct 19, 2023
4 checks passed
@EricJoy2048 EricJoy2048 changed the title [Bug] Ensure install-plugin.sh compatibility with sh on Debian #5630 [Hotfix] Ensure install-plugin.sh compatibility with sh on Debian #5630 Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [script] Shell Script install-plugin.sh Incompatibility with sh on Debian Systems
3 participants