[Feature][Connector-V2] Support TableSourceFactory/TableSinkFactory on redis #5901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hisoka-X
reviewed
Nov 23, 2023
| } | ||
|
|
||
| @Override | ||
| public void prepare(Config pluginConfig) throws PrepareFailException { | ||
| public RedisSource(Config pluginConfig) { |
There was a problem hiding this comment.
Please use ReadOnlyConfig, do not convert ReadOnlyConfig to Config. This is a bad example, we want connectors to be able to use ReadOnlyConfig instead of Config
Hisoka-X
reviewed
Nov 23, 2023
| this.hashKeyParseMode = | ||
| RedisConfig.HashKeyParseMode.valueOf( | ||
| config.getString(RedisConfig.HASH_KEY_PARSE_MODE.key()).toUpperCase()); | ||
| config.get(RedisConfig.HASH_KEY_PARSE_MODE).name().toUpperCase()); |
There was a problem hiding this comment.
After config.get(RedisConfig.HASH_KEY_PARSE_MODE). The value already are enum of HashKeyParseMode. So we don't need use valueOf to parse it again.
| this.mode = | ||
| RedisConfig.RedisMode.valueOf( | ||
| config.getString(RedisConfig.MODE.key()).toUpperCase()); | ||
| config.get(RedisConfig.MODE).name().toUpperCase()); |
Comment on lines
62
to
64
| if (config.getOptional(RedisConfig.DB_NUM).isPresent()) { | ||
| this.dbNum = config.get(RedisConfig.DB_NUM); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (config.getOptional(RedisConfig.DB_NUM).isPresent()) { | |
| this.dbNum = config.get(RedisConfig.DB_NUM); | |
| } | |
| this.dbNum = config.get(RedisConfig.DB_NUM); |
There was a problem hiding this comment.
Thank you for your review. I have made the necessary modifications PTAL @Hisoka-X
Hisoka-X
reviewed
Nov 24, 2023
Comment on lines
60
to
72
| if (config.getOptional(RedisConfig.AUTH).isPresent()) { | ||
| this.auth = config.get(RedisConfig.AUTH); | ||
| } | ||
| // set user | ||
| if (config.hasPath(RedisConfig.USER.key())) { | ||
| this.user = config.getString(RedisConfig.USER.key()); | ||
| if (config.getOptional(RedisConfig.USER).isPresent()) { | ||
| this.user = config.get(RedisConfig.USER); | ||
| } | ||
| // set mode | ||
| if (config.hasPath(RedisConfig.MODE.key())) { | ||
| this.mode = | ||
| RedisConfig.RedisMode.valueOf( | ||
| config.getString(RedisConfig.MODE.key()).toUpperCase()); | ||
| if (config.getOptional(RedisConfig.MODE).isPresent()) { | ||
| this.mode = config.get(RedisConfig.MODE); | ||
| } else { | ||
| this.mode = RedisConfig.MODE.defaultValue(); | ||
| } |
There was a problem hiding this comment.
This part also should be changed like #5901 (comment).
Because it default value already be defined in OptionRule.
Comment on lines
74
to
93
| if (config.getOptional(RedisConfig.HASH_KEY_PARSE_MODE).isPresent()) { | ||
| this.hashKeyParseMode = config.get(RedisConfig.HASH_KEY_PARSE_MODE); | ||
| } else { | ||
| this.hashKeyParseMode = RedisConfig.HASH_KEY_PARSE_MODE.defaultValue(); | ||
| } | ||
| // set redis nodes information | ||
| if (config.hasPath(RedisConfig.NODES.key())) { | ||
| this.redisNodes = config.getStringList(RedisConfig.NODES.key()); | ||
| if (config.getOptional(RedisConfig.NODES).isPresent()) { | ||
| this.redisNodes = config.get(RedisConfig.NODES); | ||
| } | ||
| // set key | ||
| if (config.hasPath(RedisConfig.KEY.key())) { | ||
| this.keyField = config.getString(RedisConfig.KEY.key()); | ||
| if (config.getOptional(RedisConfig.KEY).isPresent()) { | ||
| this.keyField = config.get(RedisConfig.KEY); | ||
| } | ||
| // set keysPattern | ||
| if (config.hasPath(RedisConfig.KEY_PATTERN.key())) { | ||
| this.keysPattern = config.getString(RedisConfig.KEY_PATTERN.key()); | ||
| if (config.getOptional(RedisConfig.KEY_PATTERN).isPresent()) { | ||
| this.keysPattern = config.get(RedisConfig.KEY_PATTERN); | ||
| } | ||
| if (config.hasPath(RedisConfig.EXPIRE.key())) { | ||
| this.expire = config.getLong(RedisConfig.EXPIRE.key()); | ||
| if (config.getOptional(RedisConfig.EXPIRE).isPresent()) { | ||
| this.expire = config.get(RedisConfig.EXPIRE); | ||
| } |
There was a problem hiding this comment.
thanks i know
hailin0
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
[Feature][Connector-V2] Support TableSourceFactory/TableSinkFactory on redis #5651 #5897
Does this PR introduce any user-facing change?
How was this patch tested?
current e2e test
Check list
New License Guide
release-note.