[Improve][Common] Adapt FILE_OPERATION_FAILED to CommonError
#5928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheneyYin
reviewed
Dec 1, 2023
seatunnel-common/src/main/java/org/apache/seatunnel/common/exception/CommonErrorCode.java
Outdated
Show resolved
Hide resolved
Hisoka-X
force-pushed
the
file-error-move
branch
from
58e9097
to
899bc78
Compare
CheneyYin
reviewed
Dec 20, 2023
...mail/src/main/java/org/apache/seatunnel/connectors/seatunnel/email/sink/EmailSinkWriter.java
Outdated
Show resolved
Hide resolved
...mail/src/main/java/org/apache/seatunnel/connectors/seatunnel/email/sink/EmailSinkWriter.java
Outdated
Show resolved
Hide resolved
CheneyYin
reviewed
Dec 21, 2023
...tunnel-core-starter/src/test/java/org/apache/seatunnel/core/starter/utils/FileUtilsTest.java
Outdated
Show resolved
Hide resolved
CheneyYin
reviewed
Dec 21, 2023
seatunnel-common/src/test/java/org/apache/seatunnel/common/utils/FileUtilsTest.java
Outdated
Show resolved
Hide resolved
CheneyYin
reviewed
Dec 21, 2023
...tunnel-core-starter/src/test/java/org/apache/seatunnel/core/starter/utils/FileUtilsTest.java
Outdated
Show resolved
Hide resolved
EricJoy2048
previously approved these changes
Dec 23, 2023
EricJoy2048
approved these changes
Dec 26, 2023
hailin0
approved these changes
Dec 26, 2023
alextinng
pushed a commit
to alextinng/seatunnel
that referenced
this pull request
Jan 4, 2024
alextinng
pushed a commit
to alextinng/seatunnel
that referenced
this pull request
Jan 4, 2024
chaorongzhi
pushed a commit
to chaorongzhi/seatunnel
that referenced
this pull request
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This PR remove
FILE_OPERATION_FAILEDtoCommonError.Does this PR introduce any user-facing change?
no
How was this patch tested?
add new test
Check list
New License Guide
release-note.