Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix] [seatunnel-starter] When inside double quotes,',' are treated as normal characters instead of delimiters #6042

Merged
merged 4 commits into from
Dec 22, 2023
Merged

[Bugfix] [seatunnel-starter] When inside double quotes,',' are treated as normal characters instead of delimiters #6042

merged 4 commits into from
Dec 22, 2023

Conversation

liugddx
Copy link
Member

@liugddx liugddx commented Dec 19, 2023 •
edited
Loading

Purpose of this pull request

close #6023

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

Hisoka-X
Hisoka-X reviewed Dec 20, 2023
View reviewed changes
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about both support ',' and ';'?

Hisoka-X
Hisoka-X reviewed Dec 20, 2023
View reviewed changes
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add test case

@liugddx liugddx changed the title [Bugfix] [seatunnel-starter] Modify the parameter separator of -i to ";" [Bugfix] [seatunnel-starter] When inside double quotes, commas are treated as normal characters instead of delimiters Dec 20, 2023
@liugddx liugddx changed the title [Bugfix] [seatunnel-starter] When inside double quotes, commas are treated as normal characters instead of delimiters [Bugfix] [seatunnel-starter] When inside double quotes,',' are treated as normal characters instead of delimiters Dec 20, 2023
Hisoka-X
Hisoka-X reviewed Dec 21, 2023
View reviewed changes
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add test case

@hailin0 hailin0 merged commit ba9733d into apache:dev Dec 22, 2023
4 checks passed
alextinng pushed a commit to alextinng/seatunnel that referenced this pull request Dec 22, 2023
@liugddx
[Bugfix] [seatunnel-starter] When inside double quotes,',' are treate…
4cbaa0c 
…d as normal characters instead of delimiters (apache#6042)
chaorongzhi pushed a commit to chaorongzhi/seatunnel that referenced this pull request Aug 21, 2024
@liugddx
[Bugfix] [seatunnel-starter] When inside double quotes,',' are treate…
33acbac 
…d as normal characters instead of delimiters (apache#6042)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hisoka-X Hisoka-X Hisoka-X approved these changes

@hailin0 hailin0 hailin0 approved these changes

@EricJoy2048 EricJoy2048 Awaiting requested review from EricJoy2048

Assignees
No one assigned
Labels
approved reviewed
Projects
None yet
Milestone
No milestone
4 participants
@liugddx @hailin0 @EricJoy2048 @Hisoka-X