Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix][API] Fix Object.class option value can not return normal value #6247

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

Hisoka-X
Copy link
Member

Purpose of this pull request

This PR fix Object.class option value can not return normal value. Like option:

        public static final Option<Object> DEFAULT_VALUE =
                Options.key("defaultValue")
                        .objectType(Object.class)
                        .noDefaultValue()
                        .withDescription("SeaTunnel Schema Column Default Value");

After this PR, it will return value which parse by jackson.

Does this PR introduce any user-facing change?

no

How was this patch tested?

add new test.

Check list

@Hisoka-X
Copy link
Member Author

cc @ruanwenjun @hailin0

@Hisoka-X Hisoka-X added this to the 2.3.4 milestone Jan 18, 2024
Copy link
Member

@hailin0 hailin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EricJoy2048 EricJoy2048 merged commit cab4d75 into apache:dev Jan 19, 2024
5 checks passed
@Hisoka-X Hisoka-X deleted the fix-object-option-cannot-parse branch January 19, 2024 02:43
chaorongzhi pushed a commit to chaorongzhi/seatunnel that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants