Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][Connector-V2][Milvus] Support Milvus source & sink #7158

Merged
merged 12 commits into from
Jul 12, 2024

Conversation

Thomas-HuWei
Copy link
Contributor

Purpose of this pull request

Support Milvus source & sink.

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

Copy link
Member

@hailin0 hailin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hailin0
Copy link
Member

hailin0 commented Jul 11, 2024

LGTM
cc @Hisoka-X
Waiting for CI passed

@hailin0
Copy link
Member

hailin0 commented Jul 11, 2024

Please check ci error

image

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Thomas-HuWei

Copy link
Member

@hailin0 hailin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hailin0 hailin0 merged commit 0c69b91 into apache:dev Jul 12, 2024
5 of 6 checks passed
hawk9821 pushed a commit to hawk9821/seatunnel that referenced this pull request Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants