Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] Skip downloading transitive dependency when install plugins #7374

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

kevinjmh
Copy link
Member

Purpose of this pull request

Skip downloading transitive dependency when install plugins to improve user experience

Does this PR introduce any user-facing change?

No

How was this patch tested?

Fresh new install local test.

Check list

Before:
image

After:
image

@Hisoka-X
Copy link
Member

Thanks @kevinjmh ! Could you follow the guide to open github action on your fork repository? https://github.com/apache/seatunnel/pull/7374/checks?check_run_id=28636510415

@kevinjmh
Copy link
Member Author

ok, it is opened now

@Hisoka-X
Copy link
Member

Try push an emtpy commit to trigger it.

@Hisoka-X
Copy link
Member

I noticed we're missing a test for the download script, would you be willing to add one in https://github.com/apache/seatunnel/tree/dev/seatunnel-e2e/seatunnel-e2e-common/src/test? Thanks.

@hailin0 hailin0 merged commit 5c08300 into apache:dev Aug 21, 2024
4 checks passed
@kevinjmh kevinjmh deleted the skipTransitiveDeps branch September 6, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants