Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hotfix][Connector-V2] Fix null not inserted in es #7493

Merged
merged 3 commits into from
Aug 26, 2024
Merged

[Hotfix][Connector-V2] Fix null not inserted in es #7493

merged 3 commits into from
Aug 26, 2024

Conversation

corgy-w
Copy link
Contributor

@corgy-w corgy-w commented Aug 25, 2024 •
edited
Loading

Purpose of this pull request

issue : #7429
Fix null values ​​are not inserted in es data migration，also fix test case

Does this PR introduce any user-facing change?

How was this patch tested?

test case

Check list

@Hisoka-X Hisoka-X linked an issue Aug 25, 2024 that may be closed by this pull request
[Bug] [mysql-cdc 同步es]如果值为NULL，ES插入的时候会被忽略 #7429
Closed
3 tasks
@Hisoka-X Hisoka-X added this to the 2.3.8 milestone Aug 25, 2024
Hisoka-X
Hisoka-X approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @corgy-w

wuchunfu
wuchunfu approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@wuchunfu wuchunfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wuchunfu wuchunfu merged commit a4ba6a1 into apache:dev Aug 26, 2024
5 checks passed
hawk9821 pushed a commit to hawk9821/seatunnel that referenced this pull request Aug 29, 2024
@corgy-w @hawk9821
[Hotfix][Connector-V2] Fix null not inserted in es (apache#7493)
c61a51d 
* [Hotfix][Connector-V2] Fix null not inserted in es

* [Hotfix][Connector-V2] update

* [Hotfix][Connector-V2] fix multi sink es test case
hawk9821 pushed a commit to hawk9821/seatunnel that referenced this pull request Aug 29, 2024
@corgy-w @hawk9821
[Hotfix][Connector-V2] Fix null not inserted in es (apache#7493)
777e617 
* [Hotfix][Connector-V2] Fix null not inserted in es

* [Hotfix][Connector-V2] update

* [Hotfix][Connector-V2] fix multi sink es test case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hisoka-X Hisoka-X Hisoka-X approved these changes

@wuchunfu wuchunfu wuchunfu approved these changes

Assignees
No one assigned
Labels
approved connectors-v2 e2e elasticsearch reviewed
Projects
None yet
Milestone
2.3.8
Development

Successfully merging this pull request may close these issues.

[Bug] [mysql-cdc 同步es]如果值为NULL，ES插入的时候会被忽略
3 participants
@corgy-w @wuchunfu @Hisoka-X