Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][Connector-V2] Fake supports column configuration #7503

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

corgy-w
Copy link
Contributor

@corgy-w corgy-w commented Aug 26, 2024

Purpose of this pull request

issue : #7492

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@Hisoka-X Hisoka-X linked an issue Aug 27, 2024 that may be closed by this pull request
3 tasks
Hisoka-X
Hisoka-X previously approved these changes Aug 27, 2024
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if ci passes. Thanks @corgy-w !

@corgy-w
Copy link
Contributor Author

corgy-w commented Aug 27, 2024

@Hisoka-X @wuchunfu Also fix dead link, merge as soon as possible if ci passes

@hailin0
Copy link
Member

hailin0 commented Aug 27, 2024

@Hisoka-X @wuchunfu Also fix dead link, merge as soon as possible if ci passes

@corgy-w
Can you submit a separate PR to fix this dead link?

@corgy-w
Copy link
Contributor Author

corgy-w commented Aug 27, 2024

@Hisoka-X @wuchunfu Also fix dead link, merge as soon as possible if ci passes

@corgy-w Can you submit a separate PR to fix this dead link?

get

Hisoka-X
Hisoka-X previously approved these changes Aug 28, 2024
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @corgy-w

@wuchunfu
Copy link
Member

@corgy-w Please resolve the conflict, thanks

Copy link
Member

@wuchunfu wuchunfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wuchunfu wuchunfu merged commit 39162a4 into apache:dev Aug 28, 2024
6 checks passed
hawk9821 pushed a commit to hawk9821/seatunnel that referenced this pull request Aug 29, 2024
* [Improve][Connector-V2] Fake supports column configuration

* [Improve][Connector-V2] optimized code
hawk9821 pushed a commit to hawk9821/seatunnel that referenced this pull request Aug 29, 2024
* [Improve][Connector-V2] Fake supports column configuration

* [Improve][Connector-V2] optimized code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][Connector-V2] Fake supports column configuration
4 participants