Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SeaTunnel #910] Support spark-hive sink #911

Merged
merged 3 commits into from
Jan 1, 2022
Merged

[SeaTunnel #910] Support spark-hive sink #911

merged 3 commits into from
Jan 1, 2022

Conversation

simon824
Copy link
Member

Purpose of this pull request

closes #910

Check list

@simon824 simon824 changed the title [SeaTunnel #910 ] Support spark-hive sink [SeaTunnel #910] Support spark-hive sink Dec 31, 2021
RickyHuo
RickyHuo requested changes Dec 31, 2021
View reviewed changes
Copy link
Contributor

@RickyHuo RickyHuo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the Hive.md-Options, the redirect of param name is invalid. Please check it.

You should write like this

 | [save_mode](#save_mode-string)      | string        | no       | -             |

docs/en/configuration/sink-plugins/Hive.md Outdated Show resolved Hide resolved
@simon824
Copy link
Member Author

simon824 commented Jan 1, 2022

In the Hive.md-Options, the redirect of param name is invalid. Please check it.

You should write like this

 | [save_mode](#save_mode-string)      | string        | no       | -             |

Updated, thanks for your review.

RickyHuo
RickyHuo approved these changes Jan 1, 2022
View reviewed changes
Copy link
Contributor

@RickyHuo RickyHuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CalvinKirs CalvinKirs merged commit 2f7b9fa into apache:dev Jan 1, 2022
@CalvinKirs CalvinKirs mentioned this pull request Jan 6, 2022
Open
54 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RickyHuo RickyHuo RickyHuo approved these changes

Assignees

@simon824 simon824

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature][Plugin] Support spark-hive sink
3 participants
@simon824 @RickyHuo @CalvinKirs