[SEDONA-558] Fix and improve SedonaPyDeck behavior #1415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiayuasu
requested changes
May 17, 2024
jiayuasu
requested changes
May 17, 2024
jiayuasu
requested changes
May 17, 2024
There was a problem hiding this comment.
Why is this PR changing these files?
There was a problem hiding this comment.
They are phony changes, these changes have been merged before.
|
To test if the API key has been added successfully is not possible. However, I can add tests for other behavior changes. |
jiayuasu
approved these changes
May 18, 2024
Kontinuation
pushed a commit
to Kontinuation/sedona
that referenced
this pull request
Oct 11, 2024
* fix: python dataframe API constructor Function registrations * fix: SedonaPyDeck behavior as per expectation * docs: update docs * docs: update docs 2 * chore: add test for SedonaPyDeck * chore: add test for SedonaPyDeck 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[SEDONA-XXX] my subjectDescription
Current implementation
Adds the optional parameters
map_style, andmap_provideras data members to the pdk map object.eg: map_p.map_style = map_style
The current behavior of PyDeck doesn't update the map object with the additional configuration added via data members.
Behavior of PyDeck
map_styleis 'dark' andmap_provideris 'carto'. If you configuremap_styleto 'satellite' it will not change themap_providerto Mapbox or Google Maps API.What changes were proposed in this PR?
api_keyparameter of PyDeckmap_styleis set to 'satellite' and ifmap_provideris Carto (the default).How was this patch tested?
Did this PR include necessary documentation updates?