Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GeoSpark Core Python API #394 #417

Merged
merged 18 commits into from
Feb 3, 2020
Merged

Add GeoSpark Core Python API #394 #417

merged 18 commits into from
Feb 3, 2020

Conversation

Imbruced
Copy link
Member

@Imbruced Imbruced commented Feb 2, 2020

Is this PR related to a proposed Issue?

#394

What changes were proposed in this PR?

GeoSpark Core Python API

How was this patch tested?

over 400 unit tests (some of them are rewritten from GeoSpark Java/Scala code)

Did this PR include necessary documentation updates?

Yes, docs/tutorial/geo_spark_core_python.md

@Imbruced Imbruced self-assigned this Feb 2, 2020
@jiayuasu jiayuasu merged commit 776e558 into apache:master Feb 3, 2020
jiayuasu pushed a commit that referenced this pull request Feb 3, 2020
* Fix Issue, unread block data (#408)

* Add GeoSpark core Python API, version beta.

* Fix issue with additional else statement.

* Add WkbReader to direct imports, Fix issue with version tests.

* Add geo_pyspark version 0.3.0.

* Add geo_pyspark version 0.3.0.

* Update wheel file for geo_pyspark version 0.3.0.

* Improve serialization process for GeoSpark Python.

* Fix Issue with Adapter import.

* Create example notebook for GeoPysparkSQL and GeoPysparkCore.

* Delete ShowCase Notebook.ipynb

* Update GeoSparkCore example notebook.

* Update code for DataBricks platform support.

* Add support for collect SpatialPartitionedRDD.

* Add persist possibility to indexedRDD.

* Add support for serializing rawSpatialRDD.

* Update wheel file for geo_pyspark version 0.3.0.

# Conflicts:
#	docs/tutorial/geospark-python.md
#	mkdocs.yml
jiayuasu pushed a commit that referenced this pull request Feb 3, 2020
* Fix Issue, unread block data (#408)

* Add GeoSpark core Python API, version beta.

* Fix issue with additional else statement.

* Add WkbReader to direct imports, Fix issue with version tests.

* Add geo_pyspark version 0.3.0.

* Add geo_pyspark version 0.3.0.

* Update wheel file for geo_pyspark version 0.3.0.

* Improve serialization process for GeoSpark Python.

* Fix Issue with Adapter import.

* Create example notebook for GeoPysparkSQL and GeoPysparkCore.

* Delete ShowCase Notebook.ipynb

* Update GeoSparkCore example notebook.

* Update code for DataBricks platform support.

* Add support for collect SpatialPartitionedRDD.

* Add persist possibility to indexedRDD.

* Add support for serializing rawSpatialRDD.

* Update wheel file for geo_pyspark version 0.3.0.

# Conflicts:
#	docs/tutorial/geospark-python.md
#	mkdocs.yml
@jiayuasu
Copy link
Member

jiayuasu commented Feb 3, 2020

@Imbruced Hi Pawel, thank you very much for this PR and thank you for your hard work.

Having said that, I have noticed a couple of things that we should do in order to draw GeoSpark 1.3.0 release. As we agreed, GeoSpark 1.3.0 will include two separate parts, Scala/Java API (which are jars hosted on Maven Central) and Python (which are packages hosted on PyPi)

First of all, I have made a cut on GeoSpark Scala/Java API on core, SQL and Viz components, for Spark 2.1, 2.2., 2.3+. You now can find them on Maven Central.

For GeoSpark RDD Python and SQL Python API,

  1. Can you please make them have the same version numbering with GeoSpark, i.e., 1.3.0? So the users won't be confused by inconsistent version numbers.
  2. Can you please upload the release of all GeoSpark Python code to PyPI using the account that shared by me? In GeoSpark python tutorials, I saw you mentioned "pip install geo_pyspark" but I didn't see the corresponding release on our PyPI account.

Does this make sense? Please feel free to correct me.

@Imbruced
Copy link
Member Author

Imbruced commented Feb 3, 2020

Hi,

  1. I can use your version numbering. 
  2. Currently I am uploading library on Test PyPI https://test.pypi.org/project/geo-pyspark/. I want to be sure that everything works as it should. After that process I will release official version on PyPI and update existing documentation and create next PR.
    Regards,
    Paweł

@Imbruced
Copy link
Member Author

Imbruced commented Feb 3, 2020

GeoSpark Python is available on PyPi https://pypi.org/project/geo-pyspark/ :)
I created pull request with changes (docs etc.).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants