-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SCB-993 search sc cluster when key mismatch with aggregator cache #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #493 +/- ##
=========================================
- Coverage 59.74% 59.25% -0.5%
=========================================
Files 165 166 +1
Lines 13796 13880 +84
=========================================
- Hits 8243 8224 -19
- Misses 4973 5072 +99
- Partials 580 584 +4
Continue to review full report at Codecov.
|
little-cui
force-pushed
the
bug
branch
5 times, most recently
from
November 19, 2018 15:24
3c6d606
to
16d080b
Compare
little-cui
changed the title
WIP: SCB-993 search sc cluster when key mismatch with aggregator cache
SCB-993 search sc cluster when key mismatch with aggregator cache
Nov 20, 2018
little-cui
changed the title
SCB-993 search sc cluster when key mismatch with aggregator cache
WIP: SCB-993 search sc cluster when key mismatch with aggregator cache
Nov 20, 2018
little-cui
force-pushed
the
bug
branch
3 times, most recently
from
November 20, 2018 16:52
594d6c3
to
ea8bf4a
Compare
little-cui
commented
Nov 21, 2018
little-cui
commented
Nov 21, 2018
little-cui
changed the title
WIP: SCB-993 search sc cluster when key mismatch with aggregator cache
SCB-993 search sc cluster when key mismatch with aggregator cache
Nov 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow this checklist to help us incorporate your contribution quickly and easily:
[SCB-XXX] Fixes bug in ApproximateQuantiles
, where you replaceSCB-XXX
with the appropriate JIRA issue.go build
go test
go fmt
go vet
to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.