Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCB-993 search sc cluster when key mismatch with aggregator cache #493

Merged
merged 5 commits into from
Nov 21, 2018

Conversation

little-cui
Copy link
Member

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run go build go test go fmt go vet to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@little-cui little-cui self-assigned this Nov 19, 2018
@codecov-io
Copy link

codecov-io commented Nov 19, 2018

Codecov Report

Merging #493 into master will decrease coverage by 0.49%.
The diff coverage is 25.44%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #493     +/-   ##
=========================================
- Coverage   59.74%   59.25%   -0.5%     
=========================================
  Files         165      166      +1     
  Lines       13796    13880     +84     
=========================================
- Hits         8243     8224     -19     
- Misses       4973     5072     +99     
- Partials      580      584      +4
Impacted Files Coverage Δ
server/service/event/instance_event_handler.go 7.54% <0%> (-0.3%) ⬇️
pkg/util/util.go 62.02% <0%> (-4.2%) ⬇️
...rver/plugin/pkg/discovery/servicecenter/indexer.go 0% <0%> (-35%) ⬇️
...erver/plugin/pkg/discovery/servicecenter/cacher.go 33.33% <0%> (ø) ⬆️
server/service/util/util.go 80% <0%> (-10%) ⬇️
server/service/event/dependency_event_handler.go 15.17% <0%> (-0.14%) ⬇️
scctl/pkg/plugin/diagnose/diagnose.go 64.77% <0%> (ø) ⬆️
...rver/plugin/pkg/discovery/servicecenter/adaptor.go 0% <0%> (ø) ⬆️
server/service/event/rule_event_handler.go 8.33% <0%> (-0.37%) ⬇️
server/service/event/tag_event_handler.go 7.14% <0%> (-0.27%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a0b1fd...bcee692. Read the comment docs.

@coveralls
Copy link

coveralls commented Nov 19, 2018

Coverage Status

Coverage decreased (-0.4%) to 61.748% when pulling bcee692 on little-cui:bug into 0a0b1fd on apache:master.

@little-cui little-cui changed the title WIP: SCB-993 search sc cluster when key mismatch with aggregator cache SCB-993 search sc cluster when key mismatch with aggregator cache Nov 20, 2018
@little-cui little-cui changed the title SCB-993 search sc cluster when key mismatch with aggregator cache WIP: SCB-993 search sc cluster when key mismatch with aggregator cache Nov 20, 2018
@little-cui little-cui changed the title WIP: SCB-993 search sc cluster when key mismatch with aggregator cache SCB-993 search sc cluster when key mismatch with aggregator cache Nov 21, 2018
@little-cui little-cui merged commit 4942829 into apache:master Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants