Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract AlterResourceGroupStatement, BinlogStatement, CacheIndexStatement... to reduce duplicate logic for MySQL and doris #31761

Merged
merged 9 commits into from
Jun 19, 2024

Conversation

strongduanmu
Copy link
Member

@strongduanmu strongduanmu commented Jun 19, 2024

Fixes #ISSUSE_ID.

Changes proposed in this pull request:

  • Extract AlterResourceGroupStatement to reduce duplicate logic for MySQL and doris
  • Extract BinlogStatement to reduce duplicate logic for MySQL and doris
  • Extract CacheIndexStatement to reduce duplicate logic for MySQL and doris
  • Extract ChecksumTableStatement to reduce duplicate logic for MySQL and doris
  • Extract CheckTableStatement to reduce duplicate logic for MySQL and doris
  • Extract CloneActionSegment to reduce duplicate logic for MySQL and doris
  • Extract CreateLoadableFunctionStatement to reduce duplicate logic for MySQL and doris
  • Extract CreateResourceGroupStatement to reduce duplicate logic for MySQL and doris
  • Extract DelimiterStatement to reduce duplicate logic for MySQL and doris

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@strongduanmu strongduanmu added this to the 5.5.1 milestone Jun 19, 2024
@strongduanmu strongduanmu changed the title Extract AlterResourceGroupStatement to reduce duplicate logic for MySQL and doris Extract AlterResourceGroupStatement, BinlogStatement, CacheIndexStatement... to reduce duplicate logic for MySQL and doris Jun 19, 2024
@strongduanmu
Copy link
Member Author

image

@FlyingZC FlyingZC merged commit 8d46bc0 into apache:master Jun 19, 2024
141 checks passed
@strongduanmu strongduanmu deleted the dev-0619 branch June 19, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants