Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make jul-to-slf4j work in ShardingSphere-Proxy only #32347

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Make jul-to-slf4j work in ShardingSphere-Proxy only #32347

merged 1 commit into from
Jul 31, 2024

Conversation

TeslaCN
Copy link
Member

@TeslaCN TeslaCN commented Jul 31, 2024 •
edited
Loading

ShardingSphere-JDBC is a SDK. When integrating ShardingSphere-JDBC into project which using JUL for logging, StackOverflowError would be occurred.

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@TeslaCN TeslaCN added type: dependencies Pull requests that update a dependency file feature: logging labels Jul 31, 2024
@TeslaCN TeslaCN added this to the 5.5.1 milestone Jul 31, 2024
@TeslaCN TeslaCN marked this pull request as ready for review July 31, 2024 14:13
@terrymanu terrymanu merged commit 65290dc into apache:master Jul 31, 2024
141 checks passed
@linghengqian linghengqian mentioned this pull request Aug 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrymanu terrymanu terrymanu approved these changes

Assignees
No one assigned
Labels
feature: logging type: dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
5.5.1
Development

Successfully merging this pull request may close these issues.
2 participants
@TeslaCN @terrymanu