Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4255, column definition information for mysql_stmt_prepare #4444

Merged
merged 3 commits into from
Feb 24, 2020
Merged

#4255, column definition information for mysql_stmt_prepare #4444

merged 3 commits into from
Feb 24, 2020

Conversation

tuohai666
Copy link
Member

Fixes #4255.

@coveralls
Copy link

coveralls commented Feb 24, 2020

Pull Request Test Coverage Report for Build 1867

  • 0 of 9 (0.0%) changed or added relevant lines in 1 file are covered.
  • 382 unchanged lines in 11 files lost coverage.
  • Overall coverage decreased (-0.01%) to 58.162%

Changes Missing Coverage Covered Lines Changed/Added Lines %
sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/mysql/command/query/binary/prepare/MySQLComStmtPrepareExecutor.java 0 9 0.0%
Files with Coverage Reduction New Missed Lines %
sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-apollo/src/main/java/org/apache/shardingsphere/orchestration/center/instance/ApolloInstance.java 1 59.46%
sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/mysql/command/query/binary/prepare/MySQLComStmtPrepareExecutor.java 2 0%
shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/segment/dml/item/AggregationProjectionSegment.java 3 0%
shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/segment/dml/item/ColumnProjectionSegment.java 3 0%
shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/segment/dml/item/ExpressionProjectionSegment.java 3 0%
sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/sharding/rewrite/token/generator/impl/TableTokenGenerator.java 10 87.18%
shardingsphere-sql-parser/shardingsphere-sql-parser-sql92/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/SQL92DMLVisitor.java 63 0%
shardingsphere-sql-parser/shardingsphere-sql-parser-sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/SQLServerDMLVisitor.java 66 0%
shardingsphere-sql-parser/shardingsphere-sql-parser-oracle/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/OracleDMLVisitor.java 67 0%
shardingsphere-sql-parser/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/PostgreSQLDMLVisitor.java 77 0%
Totals Coverage Status
Change from base Build 920: -0.01%
Covered Lines: 10614
Relevant Lines: 18249

💛 - Coveralls

@codecov-io
Copy link

Codecov Report

Merging #4444 into master will decrease coverage by 0.08%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4444      +/-   ##
============================================
- Coverage     54.64%   54.55%   -0.09%     
  Complexity      330      330              
============================================
  Files           954      954              
  Lines         18215    18249      +34     
  Branches       3374     3386      +12     
============================================
+ Hits           9953     9956       +3     
- Misses         7618     7648      +30     
- Partials        644      645       +1
Impacted Files Coverage Δ Complexity Δ
...ry/binary/prepare/MySQLComStmtPrepareExecutor.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ingsphere/sql/parser/visitor/SQLServerVisitor.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...hardingsphere/sql/parser/visitor/MySQLVisitor.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...ngsphere/sql/parser/visitor/PostgreSQLVisitor.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...ardingsphere/sql/parser/visitor/OracleVisitor.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
.../sql/parser/visitor/impl/PostgreSQLDMLVisitor.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...segment/dml/item/AggregationProjectionSegment.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
.../sql/segment/dml/item/ColumnProjectionSegment.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...hardingsphere/sql/parser/visitor/SQL92Visitor.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...e/sql/parser/sql/segment/generic/TableSegment.java 20% <0%> (ø) 0% <0%> (ø) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3f9fef...1d21c5f. Read the comment docs.

@terrymanu terrymanu self-requested a review February 24, 2020 14:23
@terrymanu terrymanu merged commit 12c47db into apache:master Feb 24, 2020
@tuohai666 tuohai666 deleted the issue-4255 branch February 24, 2020 14:28
geomonlin pushed a commit to geomonlin/incubator-shardingsphere that referenced this pull request Feb 27, 2020
…ache#4444)

* apache#4255, column definition information for mysql_stmt_prepare

* apache#4255, for comments
@terrymanu terrymanu modified the milestones: 5.0.0, 4.1.0 Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use CAPI in stmt mode ,mysql_stmt_prepare and mysql_stmt_execute return incorrect response
4 participants