-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#4255, column definition information for mysql_stmt_prepare #4444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terrymanu
requested changes
Feb 24, 2020
...e/shardingproxy/frontend/mysql/command/query/binary/prepare/MySQLComStmtPrepareExecutor.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #4444 +/- ##
============================================
- Coverage 54.64% 54.55% -0.09%
Complexity 330 330
============================================
Files 954 954
Lines 18215 18249 +34
Branches 3374 3386 +12
============================================
+ Hits 9953 9956 +3
- Misses 7618 7648 +30
- Partials 644 645 +1
Continue to review full report at Codecov.
|
terrymanu
requested changes
Feb 24, 2020
...e/shardingproxy/frontend/mysql/command/query/binary/prepare/MySQLComStmtPrepareExecutor.java
Outdated
Show resolved
Hide resolved
terrymanu
approved these changes
Feb 24, 2020
geomonlin
pushed a commit
to geomonlin/incubator-shardingsphere
that referenced
this pull request
Feb 27, 2020
…ache#4444) * apache#4255, column definition information for mysql_stmt_prepare * apache#4255, for comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4255.