-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WeOpen-Star] Add simpler client annotations with @AliasFor #3805
Comments
[WeOpen Star] I would like to help. pls assign task [1,2] to me . thanks. |
[WeOpen Star]I would like to help, Please assign task 7 to me, thanks! |
[WeOpen Star] I would like to help with task 6. Can you assign me? Many thanks. |
Hi, I'd like to work on task 3. [WeOpen Star] |
Please reply [WeOpen Star]I would like to help and task number to get the task. |
Please reply [WeOpen Star]I would like to help and task number to get the task. |
[WeOpen Star]I would like to help, task 4. |
Yes, but due to different versions, different annotations need to be supported. |
[WeOpen Star]I would like to help, please assign task 5 to me, thanks! |
…oud and shenyu-client-springmvc.
…oud and shenyu-client-springmvc.
# Conflicts: # shenyu-examples/shenyu-examples-springmvc/src/main/java/org/apache/shenyu/examples/springmvc/controller/OrderController.java
…isterServiceImpl::buildRuleDTO.
…rgedAnnotation instead.
…ingcloud` and `shenyu-client-springmvc`. (#3819) * [ISSUE #3805] Add convenience annotation like `Shenyu**Mapping` for shenyu-client-springcloud. * [ISSUE #3805] Add convenience annotation like `Shenyu**Mapping` for shenyu-client-springmvc. * [ISSUE #3805] fix check style. * [ISSUE #3805] Add methods of @RequestMapping to simpler annotations for spring-client-springcloud. * [ISSUE #3805] Add Unit Test for simpler annotations for spring-client-springcloud. * [ISSUE #3805] Add methods of @RequestMapping to simpler annotations for spring-client-springmvc. * [ISSUE #3805] Add Unit Test for simpler annotations for spring-client-springmvc. * [ISSUE #3805] Use simpler annotations for shenyu-example-springcloud. * [ISSUE #3805] Add simpler annotation for shenyu-client-springcloud and shenyu-client-springmvc. * [ISSUE #3805] Add path replace logic in AbstractShenyuClientRegisterServiceImpl::buildRuleDTO. * [ISSUE #3085] fix check style. * [ISSUE #3085] Change @AliasFor#attribute to @AliasFor#annotation. * [ISSUE #3805] Add `@AliasFor(annotation = RequestMapping.class)` in @RequestMapping#method.
@runqi-zhao @hezean How is the progress now? |
Sorry for the delay, I'll submit a PR today |
Sorry for the delay, I'll submit a PR today |
* Add simpler client annotations for motan * fix ci * fix ci * Add simpler client annotations for motan * Add simpler client annotations for motan * Add simpler client annotations for motan * fix ci * fix ci * update motan version * update motan version Co-authored-by: dragon-zhang <hailang@webuy.ai>
How to Participation
Description
As a downstream of #3485, this task needs you to add(
do not delete any existing annotations
) more simpler client annotations.For example, below is how we use
client annotation
now:Does it seem a little repetitive? We can realize combined annotation through
@AliasFor
andorg.springframework.core.annotation.AnnotatedElementUtils#findMergedAnnotation
.Notice: the newly added annotation needs to be compatible with all functions of other frameworks !
Use simplified annotations like below:
You are welcome to make suggestions !
Task List
@ShenyuRequestMapping
,@ShenyuGetMapping
,@ShenyuPostMapping
,@ShenyuPutMapping
,@ShenyuDeleteMapping
,@ShenyuPatchMapping
forshenyu-client-springmvc
; @ShawnJim@ShenyuRequestMapping
,@ShenyuGetMapping
,@ShenyuPostMapping
,@ShenyuPutMapping
,@ShenyuDeleteMapping
,@ShenyuPatchMapping
forshenyu-client-springcloud
; @ShawnJim@ShenyuService
forshenyu-client-alibaba-dubbo
; @mangoGoForward@ShenyuService
,@ShenyuDubboService
forshenyu-client-apache-dubbo
; @mangoGoForward@ShenyuMotanService
forshenyu-client-motan
; @runqi-zhao@ShenyuTarsServant
forshenyu-client-tars
; @hezean@ShenyuServerEndpoint
forshenyu-client-websocket
; @lahmXuHow to contributor
You can see this : Contributor Guide
I suggest you subscribe to shenyu dev mailing list, and when you encounter any problems, or when you finish,
you can send an email to dev@shenyu.apache.org
I suggest you git clone the source code and finish the changes. like this :
fork this to you repository : https://github.com/apache/shenyu.git
Verification
After you modify file in verify local and you can see this : How to build shenyu .
After you pull request merged. You can verify to this : en-doc , zh-doc
The text was updated successfully, but these errors were encountered: