Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize shenyu-admin #4355

Merged
merged 3 commits into from
Feb 8, 2023
Merged

optimize shenyu-admin #4355

merged 3 commits into from
Feb 8, 2023

Conversation

balloon72
Copy link
Contributor

optimize code

@KevinClair
Copy link
Member

Resolve conflicts.

@balloon72
Copy link
Contributor Author

Resolve conflicts.

rebased

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2023

Codecov Report

Merging #4355 (257bb16) into master (50371b6) will increase coverage by 0.01%.
The diff coverage is 42.85%.

@@             Coverage Diff              @@
##             master    #4355      +/-   ##
============================================
+ Coverage     68.29%   68.31%   +0.01%     
  Complexity     7502     7502              
============================================
  Files          1020     1020              
  Lines         28806    28799       -7     
  Branches       2569     2569              
============================================
- Hits          19674    19673       -1     
+ Misses         7596     7590       -6     
  Partials       1536     1536              
Impacted Files Coverage Δ
...he/shenyu/admin/controller/PlatformController.java 83.33% <0.00%> (ø)
...enyu/admin/service/impl/PermissionServiceImpl.java 34.61% <0.00%> (ø)
.../shenyu/admin/service/impl/SandboxServiceImpl.java 8.33% <0.00%> (+0.13%) ⬆️
...henyu/admin/service/impl/UpstreamCheckService.java 62.41% <ø> (-0.26%) ⬇️
...nyu/admin/service/manager/impl/DocManagerImpl.java 16.66% <0.00%> (+1.66%) ⬆️
...che/shenyu/admin/spring/LocalDataSourceLoader.java 68.57% <0.00%> (ø)
...shenyu/admin/service/impl/SyncDataServiceImpl.java 96.42% <83.33%> (+3.32%) ⬆️
.../register/FallbackShenyuClientRegisterService.java 11.11% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yu199195 yu199195 added this to the 2.6.0 milestone Feb 8, 2023
@yu199195 yu199195 merged commit 9e3c075 into apache:master Feb 8, 2023
@balloon72 balloon72 deleted the fix_4354 branch February 8, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants