Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug fiexd]A nullpointerEXException occurred when starting example-springcloud with nacos configuration. #4396

Merged

Conversation

SuperMonkeyC
Copy link
Contributor

A nullpointerEXException occurred when starting example-springcloud with nacos configuration. The associated code is in org.apache.shenyu.register.client.nacos.NacosClientRegisterRepository:nacosProperties.put(PropertyKeyConst.NAMESPACE, properties.getProperty(NAMESPACE));

Make sure that:

  • [x ] You have read the contribution guidelines.
  • [x ] You submit test cases (unit or integration tests) that back your changes.
  • [ x] Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

A nullpointerEXException occurred when starting example-springcloud with nacos configuration.
The associated code is in org.apache.shenyu.register.client.nacos.NacosClientRegisterRepository:nacosProperties.put(PropertyKeyConst.NAMESPACE, properties.getProperty(NAMESPACE));
If you do not set it, you will not be able to reproduce the demonstration of the admin project plug-in rule list on the document
@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2023

Codecov Report

Merging #4396 (845f2f2) into master (175459c) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4396      +/-   ##
============================================
- Coverage     68.25%   68.21%   -0.04%     
+ Complexity     7510     7491      -19     
============================================
  Files          1020     1020              
  Lines         28871    28871              
  Branches       2579     2579              
============================================
- Hits          19705    19695      -10     
- Misses         7624     7632       +8     
- Partials       1542     1544       +2     
Impacted Files Coverage Δ
...controller/ShenyuClientHttpRegistryController.java 63.63% <0.00%> (-18.19%) ⬇️
...ruptor/RegisterClientServerDisruptorPublisher.java 55.55% <0.00%> (-11.12%) ⬇️
...henyu/plugin/grpc/resolver/ShenyuNameResolver.java 56.38% <0.00%> (-7.45%) ⬇️
.../apache/shenyu/admin/model/dto/BatchCommonDTO.java 50.00% <0.00%> (-7.15%) ⬇️
...apache/shenyu/admin/model/dto/AuthPathWarpDTO.java 57.14% <0.00%> (-7.15%) ⬇️
...org/apache/shenyu/admin/model/dto/AuthPathDTO.java 58.82% <0.00%> (-5.89%) ⬇️
...a/org/apache/shenyu/admin/model/entity/BaseDO.java 52.17% <0.00%> (-4.35%) ⬇️
...che/shenyu/admin/model/vo/DashboardUserEditVO.java 60.86% <0.00%> (-4.35%) ⬇️
...ache/shenyu/admin/model/dto/DataPermissionDTO.java 59.25% <0.00%> (-3.71%) ⬇️
...rg/apache/shenyu/admin/model/page/CommonPager.java 44.82% <0.00%> (-3.45%) ⬇️
... and 29 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dengliming dengliming merged commit 85c0fb0 into apache:master Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants