Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[type:refactor] refactor some trie ruler codes. #4414

Merged
merged 11 commits into from
Mar 1, 2023
Merged

[type:refactor] refactor some trie ruler codes. #4414

merged 11 commits into from
Mar 1, 2023

Conversation

damonxue
Copy link
Contributor

@damonxue damonxue commented Feb 27, 2023

Refactor some trie ruler codes.

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2023

Codecov Report

Merging #4414 (d5a6b9d) into master (a842a3b) will decrease coverage by 0.08%.
The diff coverage is 54.83%.

@@             Coverage Diff              @@
##             master    #4414      +/-   ##
============================================
- Coverage     68.12%   68.04%   -0.08%     
+ Complexity     7486     7482       -4     
============================================
  Files          1021     1021              
  Lines         28913    28913              
  Branches       2584     2583       -1     
============================================
- Hits          19697    19675      -22     
- Misses         7674     7696      +22     
  Partials       1542     1542              
Impacted Files Coverage Δ
.../shenyu/admin/model/entity/OperationRecordLog.java 95.00% <ø> (ø)
...pache/shenyu/plugin/base/AbstractShenyuPlugin.java 44.26% <0.00%> (ø)
...pache/shenyu/plugin/base/cache/MatchDataCache.java 100.00% <ø> (ø)
...henyu/plugin/base/trie/ShenyuTrieRuleListener.java 0.00% <0.00%> (ø)
...e/shenyu/web/controller/LocalPluginController.java 94.62% <66.66%> (-0.06%) ⬇️
...org/apache/shenyu/plugin/base/trie/ShenyuTrie.java 69.94% <71.42%> (-0.06%) ⬇️
.../client/server/consul/ShenyuConsulConfigWatch.java 63.82% <0.00%> (-23.41%) ⬇️
...controller/ShenyuClientHttpRegistryController.java 63.63% <0.00%> (-18.19%) ⬇️
...ruptor/RegisterClientServerDisruptorPublisher.java 55.55% <0.00%> (-11.12%) ⬇️
...henyu/plugin/grpc/resolver/ShenyuNameResolver.java 56.38% <0.00%> (-5.32%) ⬇️
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

moremind
moremind previously approved these changes Mar 1, 2023
@moremind moremind merged commit 18b3ac1 into apache:master Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants