Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4381] Fix missing HOST header delete operation #4425

Merged
merged 5 commits into from
Mar 8, 2023

Conversation

iwangjie
Copy link
Contributor

@iwangjie iwangjie commented Mar 3, 2023

FIX #4381 missing HOST header delete operation

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@iwangjie iwangjie changed the title FIX #4381 missing HOST header delete operation [ISSUE #4381] Fix missing HOST header delete operation Mar 3, 2023
@moremind moremind requested a review from yu199195 March 3, 2023 06:44
@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2023

Codecov Report

Merging #4425 (3750d8f) into master (bf7820f) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #4425      +/-   ##
============================================
- Coverage     68.01%   68.01%   -0.01%     
- Complexity     7534     7535       +1     
============================================
  Files          1026     1026              
  Lines         29099    29100       +1     
  Branches       2611     2611              
============================================
- Hits          19793    19791       -2     
  Misses         7748     7748              
- Partials       1558     1561       +3     
Impacted Files Coverage Δ
...yu/plugin/httpclient/AbstractHttpClientPlugin.java 40.84% <100.00%> (+0.84%) ⬆️
...yu/sync/data/http/refresh/AbstractDataRefresh.java 68.96% <0.00%> (-13.80%) ⬇️
...che/shenyu/sync/data/http/HttpSyncDataService.java 81.63% <0.00%> (-8.17%) ⬇️
...henyu/common/cache/MemorySafeWindowTinyLFUMap.java 73.33% <0.00%> (ø)
...henyu/admin/service/impl/UpstreamCheckService.java 66.66% <0.00%> (+0.57%) ⬆️
...henyu/plugin/grpc/resolver/ShenyuNameResolver.java 60.63% <0.00%> (+4.25%) ⬆️
...ruptor/RegisterClientServerDisruptorPublisher.java 66.66% <0.00%> (+11.11%) ⬆️
...controller/ShenyuClientHttpRegistryController.java 81.81% <0.00%> (+18.18%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yu199195 yu199195 added type: bug Something isn't working type: refactor labels Mar 8, 2023
@yu199195 yu199195 added this to the 2.6.0 milestone Mar 8, 2023
@yu199195 yu199195 merged commit 60a5da4 into apache:master Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working type: refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] The Host field is set incorrectly when the upstream is reverse proxy.
5 participants