Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ShenyuTrie NPE #4533

Merged
merged 2 commits into from
Apr 5, 2023
Merged

fix ShenyuTrie NPE #4533

merged 2 commits into from
Apr 5, 2023

Conversation

lan-dian
Copy link
Contributor

@lan-dian lan-dian commented Apr 4, 2023

fix #4530 This is my first pr and I will continue to contribute

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@lan-dian
Copy link
Contributor Author

lan-dian commented Apr 4, 2023

@moremind Could you please help me advance the test process? Thank you.

@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2023

Codecov Report

Merging #4533 (14977d6) into master (df6d9c7) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #4533      +/-   ##
============================================
- Coverage     68.53%   68.52%   -0.01%     
  Complexity     7632     7632              
============================================
  Files          1028     1028              
  Lines         29441    29443       +2     
  Branches       2666     2667       +1     
============================================
- Hits          20178    20177       -1     
- Misses         7666     7667       +1     
- Partials       1597     1599       +2     
Impacted Files Coverage Δ
...org/apache/shenyu/plugin/base/trie/ShenyuTrie.java 69.02% <0.00%> (-0.76%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lan-dian
Copy link
Contributor Author

lan-dian commented Apr 5, 2023

@moremind Hello, I have passed the unit test. Could you please help me review it? Thank you. 😄

@yu199195 yu199195 added the type: bug Something isn't working label Apr 5, 2023
@yu199195 yu199195 added this to the 2.6.0 milestone Apr 5, 2023
@yu199195 yu199195 merged commit 1239d35 into apache:master Apr 5, 2023
@lan-dian lan-dian deleted the fix_trie_npe branch April 5, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] ShenYuTrie will report NPE under high concurrency
3 participants