Optimize Trie code and improve wildcard * support #4569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4569 +/- ##
=========================================
Coverage 68.84% 68.84%
- Complexity 7735 7744 +9
=========================================
Files 1033 1033
Lines 29577 29606 +29
Branches 2673 2680 +7
=========================================
+ Hits 20361 20381 +20
- Misses 7618 7621 +3
- Partials 1598 1604 +6
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
moremind
requested changes
Apr 18, 2023
...u-plugin/shenyu-plugin-base/src/main/java/org/apache/shenyu/plugin/base/trie/ShenyuTrie.java
Outdated
Show resolved
Hide resolved
moremind
requested changes
Apr 18, 2023
...u-plugin/shenyu-plugin-base/src/main/java/org/apache/shenyu/plugin/base/trie/ShenyuTrie.java
Outdated
Show resolved
Hide resolved
moremind
approved these changes
Apr 19, 2023
yu199195
pushed a commit
to yu199195/shenyu
that referenced
this pull request
May 5, 2023
* code optimization * support wildcard * characters * bugfix : not support /**/*.json * codestyle check * uniform code format --------- Co-authored-by: likeguo <33576070+li-keguo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize Trie code and improve wildcard * support，such as .html，.jpg , or even ShenYu.
Make sure that:
./mvnw clean install -Dmaven.javadoc.skip=true.