Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Trie code and improve wildcard * support #4569

Merged
merged 8 commits into from
Apr 19, 2023

Conversation

lan-dian
Copy link
Contributor

Optimize Trie code and improve wildcard * support,such as .html,.jpg , or even ShenYu.

Make sure that:

  • [ ] You have read the contribution guidelines.
  • [ ] You submit test cases (unit or integration tests) that back your changes.
  • [ ] Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2023

Codecov Report

Merging #4569 (36c282f) into master (f09938d) will increase coverage by 0.00%.
The diff coverage is 78.86%.

@@            Coverage Diff            @@
##             master    #4569   +/-   ##
=========================================
  Coverage     68.84%   68.84%           
- Complexity     7735     7744    +9     
=========================================
  Files          1033     1033           
  Lines         29577    29606   +29     
  Branches       2673     2680    +7     
=========================================
+ Hits          20361    20381   +20     
- Misses         7618     7621    +3     
- Partials       1598     1604    +6     
Impacted Files Coverage Δ
...org/apache/shenyu/plugin/base/trie/ShenyuTrie.java 76.44% <78.86%> (-1.96%) ⬇️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lan-dian lan-dian requested a review from moremind April 19, 2023 01:28
@moremind moremind merged commit 13b2b98 into apache:master Apr 19, 2023
yu199195 pushed a commit to yu199195/shenyu that referenced this pull request May 5, 2023
* code optimization

* support wildcard * characters

* bugfix : not support /**/*.json

* codestyle check

* uniform code format

---------

Co-authored-by: likeguo <33576070+li-keguo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants