Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4029] link part #4591

Merged
merged 16 commits into from
Apr 30, 2023
Merged

Conversation

loongs-zhang
Copy link
Member

@loongs-zhang loongs-zhang commented Apr 26, 2023

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2023

Codecov Report

Merging #4591 (c693892) into master (213caf9) will decrease coverage by 0.22%.
The diff coverage is 16.56%.

@@             Coverage Diff              @@
##             master    #4591      +/-   ##
============================================
- Coverage     69.39%   69.17%   -0.22%     
+ Complexity     7830     7822       -8     
============================================
  Files          1037     1037              
  Lines         29816    29901      +85     
  Branches       2725     2726       +1     
============================================
- Hits          20691    20685       -6     
- Misses         7499     7595      +96     
+ Partials       1626     1621       -5     
Impacted Files Coverage Δ
...alibaba/dubbo/AlibabaDubboServiceBeanListener.java 0.00% <0.00%> (ø)
...t/apache/dubbo/ApacheDubboServiceBeanListener.java 0.00% <0.00%> (ø)
...ache/shenyu/admin/service/impl/ApiServiceImpl.java 24.44% <3.48%> (-17.81%) ⬇️
...client/brpc/BrpcContextRefreshedEventListener.java 69.01% <50.00%> (-0.56%) ⬇️
...t/springmvc/init/SpringMvcClientEventListener.java 76.19% <75.00%> (-0.58%) ⬇️
...ringcloud/init/SpringCloudClientEventListener.java 71.96% <88.88%> (+1.48%) ⬆️
.../apache/shenyu/admin/controller/ApiController.java 85.71% <100.00%> (ø)
...enyu/client/tars/TarsServiceBeanEventListener.java 80.45% <100.00%> (+0.91%) ⬆️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

tagRelationMapper.deleteByApiId(apiDO.getId());
tagRelationMapper.batchInsert(tags);
}
if (ApiStateEnum.PUBLISHED.getState() == apiDO.getState()) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

used Objects.equals

add state is @NotNull

@li-keguo li-keguo merged commit 0574b36 into apache:master Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants