Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[type:fix] fix logging console thread safety #4763

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

moremind
Copy link
Member

@moremind moremind commented Jun 25, 2023

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2023

Codecov Report

Merging #4763 (b36f7d1) into master (5531229) will increase coverage by 0.05%.
The diff coverage is 83.33%.

@@             Coverage Diff              @@
##             master    #4763      +/-   ##
============================================
+ Coverage     66.35%   66.40%   +0.05%     
- Complexity     8113     8117       +4     
============================================
  Files          1121     1121              
  Lines         32566    32574       +8     
  Branches       2937     2937              
============================================
+ Hits          21608    21631      +23     
+ Misses         9244     9227      -17     
- Partials       1714     1716       +2     
Impacted Files Coverage Δ
...u/plugin/logging/common/AbstractLoggingPlugin.java 0.00% <0.00%> (ø)
...u/plugin/logging/console/LoggingConsolePlugin.java 50.39% <93.33%> (+2.89%) ⬆️
...in/logging/common/utils/LogCollectConfigUtils.java 73.80% <100.00%> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@moremind moremind added this to the 2.6.0 milestone Jun 25, 2023
@yu199195 yu199195 merged commit 9ec3317 into apache:master Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants