Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[type Refactor]extractor add BaseAnnotationApiBeansExtractor #4787

Merged

Conversation

li-keguo
Copy link
Member

@li-keguo li-keguo commented Jul 2, 2023

about issue #4560

work list:

  • add BaseAnnotationApiBeansExtractor.
  • Refactor SpringCloudApiBeansExtractor.
  • Refactor SpringMvcApiBeansExtractor.

@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2023

Codecov Report

Merging #4787 (3167ab4) into master (eca1211) will decrease coverage by 0.12%.
The diff coverage is 48.07%.

@@             Coverage Diff              @@
##             master    #4787      +/-   ##
============================================
- Coverage     65.62%   65.51%   -0.12%     
- Complexity     8144     8147       +3     
============================================
  Files          1133     1135       +2     
  Lines         33162    33236      +74     
  Branches       2969     2967       -2     
============================================
+ Hits          21764    21773       +9     
- Misses         9667     9734      +67     
+ Partials       1731     1729       -2     
Impacted Files Coverage Δ
...ter/extractor/BaseAnnotationApiBeansExtractor.java 0.00% <0.00%> (ø)
...core/register/extractor/BaseApiBeansExtractor.java 0.00% <0.00%> (ø)
...nyuSpringCloudClientInfoRegisterConfiguration.java 0.00% <0.00%> (ø)
...henyuSpringMvcClientInfoRegisterConfiguration.java 0.00% <0.00%> (ø)
...rg/apache/shenyu/client/core/register/ApiBean.java 53.84% <49.12%> (-17.27%) ⬇️
...ngcloud/register/SpringCloudApiBeansExtractor.java 73.07% <75.00%> (-9.07%) ⬇️
...springmvc/register/SpringMvcApiBeansExtractor.java 87.50% <94.44%> (+5.35%) ⬆️
...re/register/registrar/AbstractApiDocRegistrar.java 94.02% <100.00%> (+0.09%) ⬆️
...ringcloud/register/SpringCloudApiMetaRegister.java 93.54% <100.00%> (+0.10%) ⬆️
...t/springmvc/register/SpringMvcApiMetaRegister.java 90.90% <100.00%> (+0.13%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tian-pengfei
Copy link
Contributor

Wonderful improvement!

@tian-pengfei tian-pengfei merged commit dcd96cc into apache:master Jul 3, 2023
@li-keguo li-keguo deleted the feature/client-annoutation-supported branch July 4, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants