Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature shenyu-plugin:add shenyu-plugin-logging-huawei-lts #4812

Merged
merged 53 commits into from
Jul 13, 2023

Conversation

xcsnx
Copy link
Member

@xcsnx xcsnx commented Jul 6, 2023

Fixes #4829

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2023

Codecov Report

Attention: Patch coverage is 75.25773% with 48 lines in your changes missing coverage. Please review.

Project coverage is 64.72%. Comparing base (504ac8e) to head (a164d06).
Report is 406 commits behind head on master.

Files with missing lines Patch % Lines
...ugin/huawei/lts/config/HuaweiLogCollectConfig.java 72.52% 18 Missing and 7 partials ⚠️
...n/huawei/lts/client/HuaweiLtsLogCollectClient.java 73.17% 17 Missing and 5 partials ⚠️
...in/huawei/lts/collector/HuaweiLtsLogCollector.java 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4812      +/-   ##
============================================
+ Coverage     64.54%   64.72%   +0.17%     
- Complexity     8172     8219      +47     
============================================
  Files          1147     1153       +6     
  Lines         33805    33999     +194     
  Branches       3016     3041      +25     
============================================
+ Hits          21821    22005     +184     
- Misses        10260    10261       +1     
- Partials       1724     1733       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

‘xcsnx’ added 2 commits July 6, 2023 20:06
@yunlongn
Copy link
Member

yunlongn commented Jul 11, 2023

pls add data. -> ./db/upgrade/2.5.1-upgrade-2.6.0-*.sql @xcsnx

@xcsnx
Copy link
Member Author

xcsnx commented Jul 11, 2023

pls add data. -> ./db/upgrade/2.5.1-upgrade-2.6.0-*.sql @xcsnx
ok

@moremind moremind merged commit bf61e5e into apache:master Jul 13, 2023
@moremind moremind added this to the 2.6.0 milestone Jul 13, 2023
@xcsnx xcsnx deleted the lts-log-dev branch August 5, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] HuaweiCloud Lts log plugin
4 participants