Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4850] fix apollo as registry, client metadata and uri cannot be synchronized to admin #4851

Merged
merged 1 commit into from
Jul 16, 2023
Merged

Conversation

xuziyang
Copy link
Contributor

@xuziyang xuziyang commented Jul 16, 2023

  1. unified client registration metadata and admin read metadata key
  2. unified the data format of admin and client
  3. when admin starts, perform a read operation from apollo
  4. The registration of metadata is optimized. When the meta data does not change, the metadata write operation is not performed
  5. removed useless code

@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2023

Codecov Report

Merging #4851 (c8f49e1) into master (21f4dba) will increase coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4851      +/-   ##
============================================
+ Coverage     64.57%   64.61%   +0.04%     
- Complexity     8201     8202       +1     
============================================
  Files          1153     1153              
  Lines         34019    34019              
  Branches       3047     3047              
============================================
+ Hits          21967    21981      +14     
+ Misses        10314    10298      -16     
- Partials       1738     1740       +2     

see 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xuziyang xuziyang changed the title [ISSUE #4850] using apollo as register, the metadata of clien cannot be synchronized with admin [ISSUE #4850] fix apollo as registry, client metadata and uri cannot be synchronized to admin Jul 16, 2023
@yu199195 yu199195 added type: bug Something isn't working type: refactor labels Jul 16, 2023
@yu199195 yu199195 added this to the 2.6.0 milestone Jul 16, 2023
@yu199195 yu199195 merged commit ddda44b into apache:master Jul 16, 2023
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working type: refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants