Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4866]Log Observability, add necessary parameters for some important error logs. #4874

Merged
merged 85 commits into from
Jul 19, 2023

Conversation

lianjunwei
Copy link
Contributor

@lianjunwei lianjunwei commented Jul 18, 2023

#4866
Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

lianjunwei and others added 30 commits June 9, 2022 01:26
yes
 以 '#' 开始的行将被忽略,而空的提交说明将终止提交。
# Conflicts:
#	shenyu-admin/src/main/java/org/apache/shenyu/admin/service/manager/impl/SwaggerDocParser.java
ok# 以 '#' 开始的行将被忽略,而空的提交说明将终止提交。
… incorrect when micro service parameter uses "@ApiModelProperty".
…c function of the gateway management system.
@lianjunwei lianjunwei changed the title [ISSUE #4866]Log Observability, add key parameter printing to some important error logs. [ISSUE #4866]Log Observability, Add necessary parameters for some important error logs Jul 19, 2023
@lianjunwei lianjunwei changed the title [ISSUE #4866]Log Observability, Add necessary parameters for some important error logs [ISSUE #4866]Log Observability, add necessary parameters for some important error logs. Jul 19, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2023

Codecov Report

Merging #4874 (bff003a) into master (ffb4bac) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##             master    #4874      +/-   ##
============================================
- Coverage     64.53%   64.52%   -0.01%     
+ Complexity     8247     8243       -4     
============================================
  Files          1165     1165              
  Lines         34202    34204       +2     
  Branches       3063     3063              
============================================
- Hits          22072    22070       -2     
- Misses        10372    10380       +8     
+ Partials       1758     1754       -4     
Impacted Files Coverage Δ
...admin/listener/zookeeper/HttpServiceDiscovery.java 12.90% <0.00%> (ø)
...java/org/apache/shenyu/common/timer/TimerTask.java 80.00% <0.00%> (ø)
...apache/shenyu/common/utils/UpstreamCheckUtils.java 15.00% <0.00%> (ø)
...he/shenyu/common/timer/HierarchicalWheelTimer.java 86.00% <66.66%> (ø)
...a/org/apache/shenyu/web/filter/FileSizeFilter.java 100.00% <100.00%> (ø)
.../apache/shenyu/web/handler/GlobalErrorHandler.java 76.47% <100.00%> (ø)

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yu199195 yu199195 added this to the 2.6.0 milestone Jul 19, 2023
@yu199195 yu199195 merged commit 6704e6c into apache:master Jul 19, 2023
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants