-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[type:fix] Polish Code. #4945
Merged
Merged
[type:fix] Polish Code. #4945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GOODBOY008
force-pushed
the
master-polish
branch
from
August 2, 2023 06:05
6ed268e
to
6bd7cb2
Compare
Hi, please check CI |
moremind
requested changes
Aug 2, 2023
...sync-data-zookeeper/src/main/java/org/apache/shenyu/sync/data/zookeeper/ZookeeperClient.java
Outdated
Show resolved
Hide resolved
...keeper/src/main/java/org/apache/shenyu/register/client/server/zookeeper/ZookeeperClient.java
Outdated
Show resolved
Hide resolved
...ent-zookeeper/src/main/java/org/apache/shenyu/register/client/zookeeper/ZookeeperClient.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #4945 +/- ##
============================================
+ Coverage 63.91% 63.96% +0.04%
Complexity 8524 8524
============================================
Files 1207 1207
Lines 35895 35891 -4
Branches 3219 3216 -3
============================================
+ Hits 22943 22956 +13
+ Misses 11098 11080 -18
- Partials 1854 1855 +1
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
GOODBOY008
force-pushed
the
master-polish
branch
from
August 2, 2023 08:23
66c32b5
to
d222794
Compare
moremind
previously approved these changes
Aug 3, 2023
@GOODBOY008 Hi, pls check ci |
moremind
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[type:fix] Polish Code.