Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[type:fix] Polish Code. #4945

Merged
merged 8 commits into from
Aug 3, 2023
Merged

[type:fix] Polish Code. #4945

merged 8 commits into from
Aug 3, 2023

Conversation

GOODBOY008
Copy link
Member

[type:fix] Polish Code.

@loongs-zhang
Copy link
Member

Hi, please check CI

@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2023

Codecov Report

Merging #4945 (071c8fd) into master (3082629) will increase coverage by 0.04%.
Report is 1 commits behind head on master.
The diff coverage is 48.48%.

@@             Coverage Diff              @@
##             master    #4945      +/-   ##
============================================
+ Coverage     63.91%   63.96%   +0.04%     
  Complexity     8524     8524              
============================================
  Files          1207     1207              
  Lines         35895    35891       -4     
  Branches       3219     3216       -3     
============================================
+ Hits          22943    22956      +13     
+ Misses        11098    11080      -18     
- Partials       1854     1855       +1     
Files Changed Coverage Δ
...nyu/admin/service/impl/TagRelationServiceImpl.java 100.00% <ø> (ø)
...ache/shenyu/admin/service/impl/TagServiceImpl.java 61.38% <ø> (ø)
...u/admin/service/manager/impl/SwaggerDocParser.java 66.16% <0.00%> (-0.51%) ⬇️
...enyu/client/core/shutdown/ShutdownHookManager.java 0.00% <0.00%> (ø)
...henyu/plugin/brpc/spi/SharedThreadPoolFactory.java 0.00% <0.00%> (ø)
...enyu/plugin/sofa/cache/ApplicationConfigCache.java 69.72% <ø> (ø)
...ister/client/server/zookeeper/ZookeeperClient.java 89.74% <0.00%> (ø)
...nyu/register/client/zookeeper/ZookeeperClient.java 89.74% <0.00%> (ø)
...che/shenyu/registry/zookeeper/ZookeeperClient.java 86.41% <0.00%> (ø)
...yu/sdk/spring/proxy/ShenyuClientMethodHandler.java 64.51% <ø> (ø)
... and 12 more

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

moremind
moremind previously approved these changes Aug 3, 2023
@moremind
Copy link
Member

moremind commented Aug 3, 2023

@GOODBOY008 Hi, pls check ci

@moremind moremind merged commit 03a665f into apache:master Aug 3, 2023
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants