Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce the Float field type #34

Merged
merged 2 commits into from
Jan 18, 2023
Merged

Introduce the Float field type #34

merged 2 commits into from
Jan 18, 2023

Conversation

hanahmily
Copy link
Contributor

Introduce the Float field type and suppress the resource not found error on loading on-disk streams/measures.

Related to apache/skywalking#8940

@hanahmily hanahmily added the enhancement New feature or request label Jan 18, 2023
@hanahmily hanahmily added this to the 0.3.0 milestone Jan 18, 2023
@wu-sheng
Copy link
Member

Why should we suppress the resource not found error?

@hanahmily
Copy link
Contributor Author

Why should we suppress the resource not found error?

A stream or measure might not link to any index rules. Considering a measure without index rules, throwing such an error would mess up the initialization. In the OAP scenario, the installation procedure will be interrupted when loading existing measures from the disk. Then the OAP server will crash down.

@wu-sheng
Copy link
Member

Why should we suppress the resource not found error?

A stream or measure might not link to any index rules. Considering a measure without index rules, throwing such an error would mess up the initialization. In the OAP scenario, the installation procedure will be interrupted when loading existing measures from the disk. Then the OAP server will crash down.

Do you mean due to last time bug? I don't think we intend to have no rule.

@hanahmily
Copy link
Contributor Author

I don't think we intend to have no rule.

Service-level metrics don't need any index rules. All searchable tags belong to the entity(SeriesID).

Do you mean due to last time bug?

It's from an improvement more than a bug. We don't create the indexRuleBinding when there is no indexRule. But the measure initialization procedure is based on the assumption that there is an indexRuleBinding at least. That is why an indexRuleBinding not found error is raised.

@wu-sheng wu-sheng merged commit afee7a6 into main Jan 18, 2023
@wu-sheng wu-sheng deleted the float branch January 18, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants