[MAL] Meter Analyse Language ANTLR4 Implement #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wu-sheng
reviewed
Jan 1, 2024
Comment on lines
54
to
55
| CLOSE_CURLY : '}' -> popMode; // 遇到 '}' 时返回到默认模式 | ||
| CLOSURE_CONTENT : ~[{}]+ ; // 匹配除了 '}' 之外的任何字符 |
There was a problem hiding this comment.
Please make sure, everything in the ASF stays in English. Remember, we are being used by global users.
wu-sheng
reviewed
Jan 1, 2024
Comment on lines
+26
to
+30
| groovyExpr: | ||
| IDENTIFIER DOT IDENTIFIER | ||
| | CLASS_NAME DOT groovyMethodCall | ||
| | groovyExpr DOT groovyMethodCall | ||
| | groovyMethodCall |
There was a problem hiding this comment.
Don't put the groovy** in new logic. You are going to replace the existing MAL engine, whether it is groovy based doesn't matter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.