Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cert-manager sub-chart as quick start #115

Merged
merged 1 commit into from
Mar 24, 2023
Merged

Add cert-manager sub-chart as quick start #115

merged 1 commit into from
Mar 24, 2023

Conversation

kezhenxu94
Copy link
Member

Also unify the feature switch name to enabled.

Also unify the feature switch name to `enabled`.
@innerpeacez
Copy link
Member

Hi, Could we make a tools chart to do these things, tools chart to dependent on our oap, operator chart. @kezhenxu94

@kezhenxu94
Copy link
Member Author

Hi, Could we make a tools chart to do these things, tools chart to dependent on our oap, operator chart. @kezhenxu94

Can you elaborate? How would that tools chart work and what does it do?

@innerpeacez
Copy link
Member

Can you elaborate? How would that tools chart work and what does it do?

Mainly, I want to deploy other things that oap needs with one-click (easy).

Later, we can make our showcases into charts. For example, otel may need opentelemetry-collector charts and ksm charts. But if oap dependent on these charts, it feels inappropriate.

I'm still not very clear what should be put in the oap or operator chart, what should be put in the tools chart.

@innerpeacez
Copy link
Member

Let the tools chart do things that are not directly related to the oap or operator. I don't know if it's good.

@kezhenxu94
Copy link
Member Author

Can you elaborate? How would that tools chart work and what does it do?

Mainly, I want to deploy other things that oap needs with one-click (easy).

Isn't that what the subchart does?

Later, we can make our showcases into charts.

I'm currently migrating showcase to Chart, and this patch is one of the things needed.

For example, otel may need opentelemetry-collector charts and ksm charts. But if oap dependent on these charts, it feels inappropriate.

Yes, so we should put these dependencies in showcase.

In my opinion the Helm Chart dependencies should be something that MUST have in order to make the main Chart work, though it can be pre-installed and we would use condition for that dependency. But optional features (like OTEL) should not add dependencies into Chart.

@kezhenxu94 kezhenxu94 merged commit 8cf4be8 into master Mar 24, 2023
@kezhenxu94 kezhenxu94 deleted the swck branch March 24, 2023 09:44
@kezhenxu94 kezhenxu94 added this to the 4.5.0 milestone Mar 26, 2023
@kezhenxu94 kezhenxu94 added the enhancement New feature or request label Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants