-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cert-manager
sub-chart as quick start
#115
Conversation
Also unify the feature switch name to `enabled`.
Hi, Could we make a tools chart to do these things, tools chart to dependent on our oap, operator chart. @kezhenxu94 |
Can you elaborate? How would that tools chart work and what does it do? |
Mainly, I want to deploy other things that oap needs with Later, we can make our showcases into charts. For example, otel may need opentelemetry-collector charts and ksm charts. But if oap dependent on these charts, it feels inappropriate. I'm still not very clear what should be put in the oap or operator chart, what should be put in the tools chart. |
Let the tools chart do things that are not directly related to the oap or operator. I don't know if it's good. |
Isn't that what the subchart does?
I'm currently migrating showcase to Chart, and this patch is one of the things needed.
Yes, so we should put these dependencies in showcase. In my opinion the Helm Chart dependencies should be something that MUST have in order to make the main Chart work, though it can be pre-installed and we would use |
Also unify the feature switch name to
enabled
.