Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt operator helm chart to v0.9.0 #146

Merged
merged 2 commits into from
Apr 28, 2024

Conversation

dashanji
Copy link
Member

  • Adapt the operator and apater helm chart to v0.9.0
  • Add the related e2e test.

Signed-off-by: Ye Cao <caoye.cao@alibaba-inc.com>
Signed-off-by: Ye Cao <caoye.cao@alibaba-inc.com>
@dashanji dashanji requested a review from hanahmily April 27, 2024 13:39
@wu-sheng wu-sheng added this to the 4.6.0 milestone Apr 27, 2024
@wu-sheng wu-sheng added the enhancement New feature or request label Apr 27, 2024
@wu-sheng
Copy link
Member

@kezhenxu94 We seem to face some incompatible changes when updated to 0.8. So, we should consider a new Helm release for bundled 0.8 SWCK.

@hanahmily hanahmily merged commit 1741f5a into apache:master Apr 28, 2024
9 checks passed
@kezhenxu94
Copy link
Member

@kezhenxu94 We seem to face some incompatible changes when updated to 0.8. So, we should consider a new Helm release for bundled 0.8 SWCK.

I think we should consider releasing swck chart on its own instead of releasing all charts in this repo for nothing, the skywalking Helm Chart in this repo has no significant change since last release.

@wu-sheng
Copy link
Member

You mean swck should have its own helm? Such as swck-helm?

@kezhenxu94
Copy link
Member

You mean swck should have its own helm? Such as swck-helm?

yes, currently skywalking-helm is only for skywalking-helm (OAP/UI), it's nothing related to swck at all, meaning swck users have to download source code to install

@wu-sheng
Copy link
Member

@dashanji @hanahmily What do you think? Should we have a thing called swck-helm to guide users?

@dashanji
Copy link
Member Author

dashanji commented Apr 29, 2024

Should we have a thing called swck-helm to guide users?

Agree. A helm chart is good for version upgrading.

@wu-sheng
Copy link
Member

@dashanji If we have an agreement, let's start a proposal to create skywalking-swck-helm repository to host this part of code and release it?

@dashanji
Copy link
Member Author

@dashanji If we have an agreement, let's start a proposal to create skywalking-swck-helm repository to host this part of code and release it?

No problem, but I don't know how to write the proposal. Is there a guide available?

@wu-sheng
Copy link
Member

It is easy, aa you are a member of PMC, just need

  • Which repository is proposed to create
  • Background and why you need this

@dashanji
Copy link
Member Author

It is easy, aa you are a member of PMC, just need

  • Which repository is proposed to create
  • Background and why you need this

Thanks for the detail. One more question,where do I need to send the proposal?

@wu-sheng
Copy link
Member

dev@skywalking.apache.org

@dashanji
Copy link
Member Author

dev@skywalking.apache.org

Thank you!

@wu-sheng
Copy link
Member

wu-sheng commented May 4, 2024

@dashanji Do you plan to ask for that after May public holiday?

@dashanji
Copy link
Member Author

dashanji commented May 5, 2024

@dashanji Do you plan to ask for that after May public holiday?

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants