Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hasSuffix replace hasPrefix #86

Merged
merged 2 commits into from
May 31, 2022
Merged

Fix hasSuffix replace hasPrefix #86

merged 2 commits into from
May 31, 2022

Conversation

geffzhang
Copy link
Contributor

@geffzhang geffzhang commented May 28, 2022 •
edited by wu-sheng
Loading

@wu-sheng wu-sheng added this to the 4.2.0 milestone May 28, 2022
@wu-sheng wu-sheng added the bug Something isn't working label May 28, 2022
dashanji
dashanji approved these changes May 28, 2022
View reviewed changes
Copy link
Member

@dashanji dashanji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested it, works as expected.

@wu-sheng
Copy link
Member

@geffzhang Would you like to follow up this PR?

@geffzhang @wu-sheng
Update chart/skywalking/templates/es-init.job.yaml
dd71f76 
Co-authored-by: 吴晟 Wu Sheng <wu.sheng@foxmail.com>
geffzhang
geffzhang commented May 31, 2022
View reviewed changes
Copy link
Contributor Author

@geffzhang geffzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use contains replace hasPrefix

@wu-sheng wu-sheng requested a review from kezhenxu94 May 31, 2022 13:47
@kezhenxu94 kezhenxu94 merged commit a7af8ba into apache:master May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wu-sheng wu-sheng wu-sheng left review comments

@kezhenxu94 kezhenxu94 kezhenxu94 approved these changes

@dashanji dashanji dashanji approved these changes

@hanahmily hanahmily Awaiting requested review from hanahmily

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.

helm install with storageType=zipkin-elasticsearch failed [skywalking-kubernetes]
4 participants
@geffzhang @wu-sheng @kezhenxu94 @dashanji