Refactor oap init job, and support postgresql storage #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wu-sheng
approved these changes
Nov 18, 2022
Comment on lines
+83
to
+85
| | `oapInit.nodeAffinity` | OAP init job node affinity policy | `{}` | | ||
| | `oapInit.nodeSelector` | OAP init job labels for master pod assignment | `{}` | | ||
| | `oapInit.tolerations` | OAP init job tolerations | `[]` | |
There was a problem hiding this comment.
These look like breaking changes, we should add breaking change warning for this?
There was a problem hiding this comment.
These look like breaking changes, we should add
breaking changewarning for this?
They are breaking change, I will have some more breaking changes soon, let me add them in the change log before 4.4.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.