Fix: Span.tag() for overridable

apache · Nov 20, 2020 · 8eabef3 · 8eabef3
1 parent 586c3b6
commit 8eabef3
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/skywalking/trace/span.py b/skywalking/trace/span.py
@@ -91,10 +91,12 @@ def tag(self, tag: Tag) -> 'Span':
             self.tags.append(deepcopy(tag))
             return self
 
-        for t in self.tags:
+        for i, t in enumerate(self.tags):
             if t.key == tag.key:
-                t.val = tag.val
+                self.tags[i] = deepcopy(tag)
                 break
+        else:
+            self.tags.append(deepcopy(tag))
 
         return self