Enhance redis plugin to adapt Virtual Cache #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wu-sheng
requested review from
pg-yang,
Superskyyy and
kezhenxu94
and removed request for
pg-yang
|
I'just a little confused. Do I have to make these checks all successful firstly? |
|
Hello @Jedore, yes you will have to make all checks pass to be eligible for a merge. The failed tests indicate problems in redis==3.5 plugin test (mismatch of expected data and reported), you can see the log in actions log. Hint: please make modifications to the https://github.com/apache/skywalking-python/blob/master/tests/plugin/data/sw_redis/expected.data.yml file to make adjustments to expected data. I'm recovering from Covid now so I don't check github very often, please ping me here when it passes, I will take a review then. |
|
All checks have passed. @Superskyyy |
Superskyyy
requested changes
Dec 31, 2022
Co-authored-by: Superskyyy (COVID) <Superskyyy@outlook.com>
pg-yang
reviewed
Jan 1, 2023
Superskyyy
approved these changes
Jan 1, 2023
|
LGTM thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #10212