Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to bring coverall test coverage comments back #3503

Merged
merged 20 commits into from
Sep 28, 2019
Merged

Try to bring coverall test coverage comments back #3503

merged 20 commits into from
Sep 28, 2019

Conversation

kezhenxu94
Copy link
Member

Please answer these questions before submitting pull request

  • Why submit this pull request?

  • Bug fix

  • New feature provided

  • Improve performance

  • Related issues


Bug fix

  • Bug description.

  • How to fix?


New feature or improvement

  • Describe the details and related test reports.

@kezhenxu94 kezhenxu94 closed this Sep 22, 2019
@kezhenxu94 kezhenxu94 reopened this Sep 22, 2019
@wu-sheng wu-sheng added this to the 6.5.0 milestone Sep 22, 2019
@wu-sheng wu-sheng added the test Test requirements about performance, feature or before release. label Sep 22, 2019
Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jacoco plugin and settings should be removed.

@kezhenxu94 kezhenxu94 added the TBD To be decided later, need more discussion or input. label Sep 22, 2019
@kezhenxu94 kezhenxu94 removed the TBD To be decided later, need more discussion or input. label Sep 22, 2019
README.md Outdated Show resolved Hide resolved
@wu-sheng
Copy link
Member

I have deleted the old repo on https://coveralls.io, asking the INFRA to set up a new one. You could follow this, https://issues.apache.org/jira/browse/INFRA-19135

@kezhenxu94
Copy link
Member Author

Seems we're making progress now
image

@wu-sheng
Copy link
Member

Finally, but still 7%? Do we set the codebase right? Is test folder included?

@wu-sheng wu-sheng merged commit 116f50e into apache:master Sep 28, 2019
@kezhenxu94 kezhenxu94 deleted the ci/coverall branch September 28, 2019 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Test requirements about performance, feature or before release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants