Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add test case for mongodb-3.x-plugin #3667

Merged
merged 14 commits into from
Oct 22, 2019
Merged

feat: add test case for mongodb-3.x-plugin #3667

merged 14 commits into from
Oct 22, 2019

Conversation

scolia
Copy link
Contributor

@scolia scolia commented Oct 21, 2019

Please answer these questions before submitting pull request

  • Why submit this pull request?
  • Bug fix
  • New feature provided
  • Improve performance

New feature or improvement

add test case for mongodb-3.x-plugin

@dmsolr dmsolr added agent Language agent related. feature New feature plugin Plugin for agent or collector. Be used to extend the capabilities of default implementor. labels Oct 21, 2019
@dmsolr dmsolr added this to the 6.5.0 milestone Oct 21, 2019
wu-sheng
wu-sheng requested changes Oct 21, 2019
View reviewed changes
Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am totally confused about this with #3591. In this PR, you include the tests for version 3.7+ clear, then what is #3591 for?

@wu-sheng wu-sheng removed this from the 6.5.0 milestone Oct 21, 2019
@wu-sheng
Copy link
Member

@dmsolr I just removed the milestone, as I didn't understand the process.

wu-sheng
wu-sheng reviewed Oct 21, 2019
View reviewed changes
Jenkinsfile-Agent-Test-3 Outdated Show resolved Hide resolved
@wu-sheng
Copy link
Member

SOFARPC tests merged, please add yours into group 1 and resolve the conflicts.

@scolia
Merge branch 'master' of https://github.com/apache/skywalking into mo…
963daa4 
…ngodb-testcase

# Conflicts:
#	Jenkinsfile-Agent-Test-3
@scolia
Merge branch 'master' of https://github.com/apache/skywalking into mo…
b78f099 
…ngodb-testcase

# Conflicts:
#	Jenkinsfile-Agent-Test-3
@scolia scolia requested a review from wu-sheng October 22, 2019 09:33
wu-sheng
wu-sheng previously approved these changes Oct 22, 2019
View reviewed changes
Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @dmsolr Please recheck.

@wu-sheng wu-sheng added this to the 6.5.0 milestone Oct 22, 2019
@wu-sheng wu-sheng requested a review from dmsolr October 22, 2019 11:46
dmsolr
dmsolr previously approved these changes Oct 22, 2019
View reviewed changes
Copy link
Member

@dmsolr dmsolr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wu-sheng wu-sheng dismissed stale reviews from dmsolr and themself via 990da57 October 22, 2019 18:10
@wu-sheng wu-sheng added the test Test requirements about performance, feature or before release. label Oct 22, 2019
@wu-sheng
Copy link
Member

Welcome to be our new contributor.

@wu-sheng wu-sheng merged commit b56248b into apache:master Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wu-sheng wu-sheng wu-sheng approved these changes

@dmsolr dmsolr dmsolr left review comments

Assignees
No one assigned
Labels
agent Language agent related. feature New feature plugin Plugin for agent or collector. Be used to extend the capabilities of default implementor. test Test requirements about performance, feature or before release.
Projects
None yet
Milestone
6.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@scolia @wu-sheng @dmsolr