Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add componentId for apache servicecomb. #3676

Merged
merged 8 commits into from
Nov 18, 2019
Merged

Add componentId for apache servicecomb. #3676

merged 8 commits into from
Nov 18, 2019

Conversation

surechen
Copy link
Contributor

@surechen surechen commented Oct 22, 2019 •
edited
Loading

Please answer these questions before submitting pull request

  • Why submit this pull request?

  • Bug fix

  • New feature provided

  • Improve performance

  • Related issues

Bug fix

  • Bug description.

  • How to fix?

New feature or improvement

  • Describe the details and related test reports.
    We want show some apache servicecomb icons in skywalking topology of call chain. Including apache/servicecomb-java-chassis, apache/servicecomb-mesher, apache/servicecomb-service-center.
    Icons are in preparation.

@wu-sheng
Copy link
Member

Do you need so many IDs? We have serivecomb id already.

@wu-sheng wu-sheng added the TBD To be decided later, need more discussion or input. label Oct 22, 2019
@surechen
Copy link
Contributor Author

surechen commented Oct 22, 2019 •
edited
Loading

Do you need so many IDs? We have serivecomb id already.

Is there any icon for servicecomb?
Because servicecomb has different assembly services. We want to identify differences in topology.
Can we keep a separate ID and icon for servicecomb-mesher and others share one same ID and icon?

@wu-sheng
Copy link
Member

Is there any icon for servicecomb?

We don't, this should be provided by service comb community.

@wu-sheng
Copy link
Member

Can we keep a separate ID and icon for servicecomb-mesher and others share one same ID and icon?

How many do you want depending on your community, and the icon for a single language or multiple languages also depends on your too. I am just asking.
Also, icon(s) should be landed in UI repo, with your test screenshot in right visualization.

@wu-sheng
Copy link
Member

More discussion happens here, https://issues.apache.org/jira/browse/SCB-1497

@wu-sheng
Copy link
Member

Please submit the icon PR and screenshot.

@wu-sheng
Copy link
Member

@surechen Any update about this PR? Is it turning to a simple purely IDs addition?

@wu-sheng
Copy link
Member

Sorry, just notice this, apache/skywalking-rocketbot-ui#169

@wu-sheng wu-sheng added this to the 6.5.0 milestone Oct 24, 2019
@wu-sheng wu-sheng removed this from the 6.5.0 milestone Oct 29, 2019
@wu-sheng wu-sheng added feature New feature backend OAP backend related. and removed TBD To be decided later, need more discussion or input. labels Nov 18, 2019
@wu-sheng wu-sheng added this to the 6.6.0 milestone Nov 18, 2019
wu-sheng
wu-sheng approved these changes Nov 18, 2019
View reviewed changes
Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am merging this. @surechen Please submit a submodule update pr.

@wu-sheng wu-sheng merged commit 96a3e34 into apache:master Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wu-sheng wu-sheng wu-sheng approved these changes

Assignees
No one assigned
Labels
backend OAP backend related. feature New feature
Projects
None yet
Milestone
6.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@surechen @wu-sheng