Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makes the scope of alarm message more semantic. #3680

Merged
merged 13 commits into from
Oct 22, 2019
Merged

Makes the scope of alarm message more semantic. #3680

merged 13 commits into from
Oct 22, 2019

Conversation

JaredTan95
Copy link
Member

@JaredTan95 JaredTan95 commented Oct 22, 2019 •
edited by wu-sheng
Loading

Please answer these questions before submitting pull request

  • Why submit this pull request?

  • Bug fix

  • New feature provided

  • Improve performance

  • Related issues
    resolves Alarm Message #3672

Bug fix

  • Bug description.

  • How to fix?

{
	"scopeId": 1, 
        "scope": "SERVICE",
        "name": "serviceA", 
	"id0": 12,  
	"id1": 0,  
        "ruleName": "service_resp_time_rule",
	"alarmMessage": "alarmMessage xxxx",
	"startTime": 1560524171000
}

New feature or improvement

  • Describe the details and related test reports.

@JaredTan95 JaredTan95 added feature New feature backend OAP backend related. labels Oct 22, 2019
@JaredTan95 JaredTan95 added this to the 6.5.0 milestone Oct 22, 2019
@wu-sheng
Copy link
Member

Could you add alarm rule name in alarm message too? I think that is meaningful too.

@JaredTan95
Copy link
Member Author

Could you add alarm rule name in alarm message too? I think that is meaningful too.

make sense to me. I will add it.

wu-sheng
wu-sheng previously approved these changes Oct 22, 2019
View reviewed changes
Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wu-sheng
Copy link
Member

/run agent-plugin-test-1

wu-sheng
wu-sheng previously approved these changes Oct 22, 2019
View reviewed changes
@wu-sheng
Copy link
Member

/run ci

@wu-sheng
Copy link
Member

@JaredTan95 unit test fails. Please recheck.

@JaredTan95
Copy link
Member Author

/run ci

@wu-sheng
Copy link
Member

/run agent-plugin-test-3

kezhenxu94
kezhenxu94 approved these changes Oct 22, 2019
View reviewed changes
Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wu-sheng wu-sheng merged commit 2f3d009 into master Oct 22, 2019
@wu-sheng wu-sheng deleted the scope_name branch October 22, 2019 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kezhenxu94 kezhenxu94 kezhenxu94 approved these changes

@wu-sheng wu-sheng wu-sheng left review comments

Assignees
No one assigned
Labels
backend OAP backend related. feature New feature
Projects
None yet
Milestone
6.5.0
Development

Successfully merging this pull request may close these issues.

Alarm Message
3 participants
@JaredTan95 @wu-sheng @kezhenxu94