pre-requirement to make istio/envoy ci test happen in CI. #3682

innerpeacez · 2019-10-22T06:19:52Z

Please answer these questions before submitting pull request

Why submit this pull request?
Bug fix
New feature provided
Improve performance
Related issues

Bug fix

Bug description.
How to fix?

New feature or improvement

Describe the details and related test reports.

hanahmily

LGTM

wu-sheng

Lack of Apache 2.0 header in many files.

install/kubernetes/helm/skywalking/Chart.yaml

wu-sheng · 2019-10-22T07:13:09Z

install/kubernetes/helm/skywalking/README.md

+        hosts:
+          - skywalking.domain.com
+```
+### Envoy ALS


This should be linked in https://github.com/apache/skywalking/blob/master/docs/en/setup/envoy/als_setting.md doc too.

wu-sheng · 2019-10-22T07:14:27Z

The old k8s doc is updated after our official release, how this works? Is it working with source code? If so, where is the process to prepare the docker image?

I am feeling the document is missing somehow.

wu-sheng · 2019-10-22T07:15:33Z

@hanahmily And with this is going to be merged, what is the agenda for skywalking-kubernetes repo? Is that repo being abandoned? Or?

innerpeacez · 2019-10-22T07:56:34Z

#3682 (comment)

resolved @wu-sheng

hanahmily · 2019-10-22T08:02:00Z

Our plan is to drop skywalking-kubernetes after an official release with kubernetes install relevant items in it. Hongtao Gao Apache SkyWalking && Apache ShardingSphere Twitter, @hanahmily

…

On Oct 22, 2019, at 3:15 PM, 吴晟 Wu Sheng ***@***.***> wrote: @hanahmily <https://github.com/hanahmily> And with this is going to be merged, what is the agenda for skywalking-kubernetes repo? Is that repo being abandoned? Or? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3682?email_source=notifications&email_token=AAO6UWMSP6DMSWDCD5W5AT3QP2SB5A5CNFSM4JDLCJUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB4YMVI#issuecomment-544835157>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAO6UWMLCPZ3TNBBN77UKXDQP2SB5ANCNFSM4JDLCJUA>.

wu-sheng · 2019-10-22T08:08:07Z

I mean the process, before merge this, I think we at least should have suitable process for release and heln update. Could we add the process to release doc?

wu-sheng · 2019-10-22T08:08:54Z

Otherwise, I have concerns. Release begin maybe in two weeks later. So, we need a clear purpose of this.

kezhenxu94 · 2019-10-22T13:34:11Z

@innerpeacez can you re-title this PR? It's too vague, note that it will become the commit message in our codebase commit history

hanahmily · 2019-10-23T02:04:53Z

Sure, let me clarify it more clear. I don’t intend to finish this task before the next release. The process should be like the following: 1. make helm yaml work with istio and envoy 2. join it into CI workflow. 3. pick up a proper date to release it So I expect that we can release it in 6.6 or 6.7. There’s a big gap between the current state and release ready.

…

On Oct 22, 2019, at 4:09 PM, 吴晟 Wu Sheng ***@***.***> wrote: Otherwise, I have concerns. Release begin maybe in two weeks later. So, we need a clear purpose of this. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3682?email_source=notifications&email_token=AAO6UWK6V7PXGYFVGHC4TKDQP2YJ5A5CNFSM4JDLCJUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB44IQY#issuecomment-544851011>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAO6UWM756ZWWJV5GQEFR7DQP2YJ5ANCNFSM4JDLCJUA>.

wu-sheng · 2019-10-23T03:51:29Z

Do you two need to collaborate in upstream code base? Or just a fork repo is good enough?
Your process is clear to me. But merge into master and release of 6.5, 6.6 are still my concern.

hanahmily · 2019-10-23T05:57:09Z

I prefer to upstream/master branch. we need latest code base to verify the process, especially in the CI step. and I know your concerns about source release, and my suggestion is to add `install` folder to “excluded” list in` create_source_release.sh`. Hongtao Gao Apache SkyWalking && Apache ShardingSphere Twitter, @hanahmily

…

On Oct 23, 2019, at 11:51 AM, 吴晟 Wu Sheng ***@***.***> wrote: Do you two need to collaborate in upstream code base? Or just a fork repo is good enough? Your process is clear to me. But merge into master and release of 6.5, 6.6 are still my concern. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3682?email_source=notifications&email_token=AAO6UWLUNZ2I4C4ISO4QKT3QP7C4VA5CNFSM4JDLCJUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB76RQI#issuecomment-545253569>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAO6UWI3MWNYHRNAFDFCWQTQP7C4VANCNFSM4JDLCJUA>.

wu-sheng · 2019-10-23T06:29:31Z

But it will still misguide user. I want to offer a branch, istio-ci, which could use jenkins and our infra too, and don't need to be concernd about release issue.
Make sense?

hanahmily · 2019-10-23T08:30:33Z

Make sense to me. @innerpeacez what you should do is: 1. close current PR 2. send a PR to branch named `install/kubernetes` 3. follow suggestion in this PR, just like "Apache license header for each files” and etc. Thanks a lot. Hongtao Gao Apache SkyWalking && Apache ShardingSphere Twitter, @hanahmily

…

On Oct 23, 2019, at 2:29 PM, 吴晟 Wu Sheng ***@***.***> wrote: But it will still misguide user. I want to offer a branch, istio-ci, which could use jenkins and our infra too, and don't need to be concernd about release issue. Make sense? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3682?email_source=notifications&email_token=AAO6UWNHBVFCI72GQAVNC4TQP7VNFA5CNFSM4JDLCJUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECAHLTA#issuecomment-545289676>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAO6UWMDU654XQJQPDOLQK3QP7VNFANCNFSM4JDLCJUA>.

innerpeacez · 2019-10-23T09:07:07Z

Does the branch name need to be discussed? install/kubernetes or istio-ci ? @wu-sheng @hanahmily

wu-sheng · 2019-10-23T10:24:07Z

We should use istio-ci. As this is a primary goal as step1.

wu-sheng · 2019-10-23T17:22:46Z

Closing this. Branch istio-ci added, please submit the PR to there. https://github.com/apache/skywalking/tree/istio-ci, and tag the issue as ci-setting in milestone 6.6.

hanahmily · 2019-10-23T22:40:39Z

Any branch name is good to me. but the goal of step1 is to make helm work with istio mixer and envoy ALS. @innerpeacez don’t try to include any CI works in step1, because slim kubernetes cluster(minikube...) may block your step. I suggest do all of related work in a hosted kubernetes cluster, for example, on-premise, AliCloud Kubernetes, EKS(AWS) and etc. I will send to issue to direct you how make it happen.

…

On Oct 23, 2019, at 6:24 PM, 吴晟 Wu Sheng ***@***.***> wrote: We should use istio-ci. As this is a primary goal as step1. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3682?email_source=notifications&email_token=AAO6UWNDPYI55QBGDWRHQV3QQAQ47A5CNFSM4JDLCJUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECA4R5A#issuecomment-545376500>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAO6UWOXIVJL2X5NA24SEKLQQAQ47ANCNFSM4JDLCJUA>.

innerpeacez · 2019-10-24T01:17:58Z

Ok, I will submit it to the istio-ci branch soon. thanks a lot. @wu-sheng @hanahmily

for #3669

e9f1f47

innerpeacez requested review from hanahmily and wu-sheng October 22, 2019 06:20

hanahmily previously approved these changes Oct 22, 2019

View reviewed changes

wu-sheng reviewed Oct 22, 2019

View reviewed changes

wu-sheng added the documentation Provide documents related issue or pull request only. label Oct 22, 2019

wu-sheng added this to the 6.5.0 milestone Oct 22, 2019

Add Apache 2.0 header

9f7f5d8

innerpeacez dismissed hanahmily’s stale review via 9f7f5d8 October 22, 2019 07:00

wu-sheng reviewed Oct 22, 2019

View reviewed changes

install/kubernetes/helm/skywalking/Chart.yaml Outdated Show resolved Hide resolved

wu-sheng reviewed Oct 22, 2019

View reviewed changes

Fixed some irrational

baeed0f

wu-sheng mentioned this pull request Oct 22, 2019

How to config envoy to upload the trace data #3685

Closed

innerpeacez changed the title ~~for #3669~~ pre-requirement to make istio/envoy ci test happen in CI. Oct 22, 2019

wu-sheng closed this Oct 23, 2019

wu-sheng added the wontfix This will not be worked on label Oct 24, 2019

innerpeacez deleted the test-envoy branch October 24, 2019 08:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pre-requirement to make istio/envoy ci test happen in CI. #3682

pre-requirement to make istio/envoy ci test happen in CI. #3682

innerpeacez commented Oct 22, 2019

hanahmily left a comment

wu-sheng left a comment

wu-sheng Oct 22, 2019

wu-sheng commented Oct 22, 2019

wu-sheng commented Oct 22, 2019

innerpeacez commented Oct 22, 2019

hanahmily commented Oct 22, 2019 via email

wu-sheng commented Oct 22, 2019

wu-sheng commented Oct 22, 2019

kezhenxu94 commented Oct 22, 2019

hanahmily commented Oct 23, 2019 via email

wu-sheng commented Oct 23, 2019

hanahmily commented Oct 23, 2019 via email

wu-sheng commented Oct 23, 2019

hanahmily commented Oct 23, 2019 via email

innerpeacez commented Oct 23, 2019

wu-sheng commented Oct 23, 2019

wu-sheng commented Oct 23, 2019

hanahmily commented Oct 23, 2019 via email

innerpeacez commented Oct 24, 2019

pre-requirement to make istio/envoy ci test happen in CI. #3682

pre-requirement to make istio/envoy ci test happen in CI. #3682

Conversation

innerpeacez commented Oct 22, 2019

Bug fix

New feature or improvement

hanahmily left a comment

Choose a reason for hiding this comment

wu-sheng left a comment

Choose a reason for hiding this comment

wu-sheng Oct 22, 2019

Choose a reason for hiding this comment

wu-sheng commented Oct 22, 2019

wu-sheng commented Oct 22, 2019

innerpeacez commented Oct 22, 2019

hanahmily commented Oct 22, 2019 via email

wu-sheng commented Oct 22, 2019

wu-sheng commented Oct 22, 2019

kezhenxu94 commented Oct 22, 2019

hanahmily commented Oct 23, 2019 via email

wu-sheng commented Oct 23, 2019

hanahmily commented Oct 23, 2019 via email

wu-sheng commented Oct 23, 2019

hanahmily commented Oct 23, 2019 via email

innerpeacez commented Oct 23, 2019

wu-sheng commented Oct 23, 2019

wu-sheng commented Oct 23, 2019

hanahmily commented Oct 23, 2019 via email

innerpeacez commented Oct 24, 2019