Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test/plugin] fix archetypes #3808

Merged
merged 3 commits into from
Nov 9, 2019
Merged

[test/plugin] fix archetypes #3808

merged 3 commits into from
Nov 9, 2019

Conversation

arugal
Copy link
Member

@arugal arugal commented Nov 8, 2019

Please answer these questions before submitting pull request

@arugal
Copy link
Member Author

arugal commented Nov 8, 2019

The new generator.sh
image
FYI @dmsolr

@wu-sheng wu-sheng requested a review from dmsolr November 8, 2019 14:17
@wu-sheng wu-sheng added agent Language agent related. bug Something isn't working and you are sure it's a bug! test Test requirements about performance, feature or before release. labels Nov 8, 2019
@wu-sheng wu-sheng added this to the 6.5.0 milestone Nov 8, 2019
@wu-sheng wu-sheng closed this Nov 8, 2019
@wu-sheng wu-sheng reopened this Nov 8, 2019
@wu-sheng
Copy link
Member

wu-sheng commented Nov 9, 2019

/run ci

<Appenders>
<Console name="Console" target="SYSTEM_ERR">
<PatternLayout charset="UTF-8" pattern="[%d{yyyy-MM-dd HH:mm:ss:SSS}] [%p] - %l - %m%n"/>
<Console name="Console" target="SYSTEM_OUT">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be System.err here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

</Console>
</Appenders>
<Loggers>
<Root level="WARN">
<Root level="info">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is higher level better. this level will print many messages.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@wu-sheng wu-sheng merged commit cbe03da into apache:master Nov 9, 2019
@arugal arugal deleted the fix-archetypes branch November 9, 2019 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent Language agent related. bug Something isn't working and you are sure it's a bug! test Test requirements about performance, feature or before release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants