-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Observing Istio control plane #5835
Conversation
Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #5835 +/- ##
============================================
- Coverage 51.22% 41.76% -9.46%
+ Complexity 3497 2898 -599
============================================
Files 1661 902 -759
Lines 35659 22527 -13132
Branches 3910 2175 -1735
============================================
- Hits 18266 9409 -8857
+ Misses 16485 12321 -4164
+ Partials 908 797 -111
Continue to review full report at Codecov.
|
oap-server/server-bootstrap/src/main/resources/oc-rules/istio-controlplane.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
...er/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/dsl/Expression.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
Co-authored-by: 吴晟 Wu Sheng <wu.sheng@foxmail.com>
oap-server/server-bootstrap/src/main/resources/otel-oc-rules/istio-controlplane.yaml
Show resolved
Hide resolved
Look like tests fail, please recheck or rerun. |
Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
7026a46
to
68cc1dd
Compare
oap-server/server-bootstrap/src/main/resources/fetcher-prom-rules/self.yaml
Show resolved
Hide resolved
Co-authored-by: 吴晟 Wu Sheng <wu.sheng@foxmail.com>
Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
I have feeling whether this PR creating too many metrics to cause the unstable. |
Yep, I also fall in with that. How about disabling Istio relevant tables generation in e2e since there is not a single test case for it. That means we don't have a test flow to guarantee whether all of the metrics work together, does it bring and concerns to you? |
Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
c7cd7ca
to
1c1144b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Istio control plane
These changes intend to add a new MAL rule and UI template to analyze and render Istio metrics exported by the Istio control plane(Istiod), main changes include:
Check list:
CHANGES
log.