Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observing Istio control plane #5835

Merged
merged 28 commits into from
Nov 25, 2020
Merged

Observing Istio control plane #5835

merged 28 commits into from
Nov 25, 2020

Conversation

hanahmily
Copy link
Contributor

@hanahmily hanahmily commented Nov 12, 2020

Istio control plane

These changes intend to add a new MAL rule and UI template to analyze and render Istio metrics exported by the Istio control plane(Istiod), main changes include:

  • MAL rule file
  • UI template file
  • Add OpenTelemetry receiver to replace OpenCensus receiver
  • Create metric tables or indices on the initial phase instead of runtime.
  • Remove istio mixer receiver

Check list:

  • Update the documentation to include this new feature.
  • If it's UI related, attach the screenshots below.
  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes Support Istio control panel metrics. #5810 .
  • Update the CHANGES log.

Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
@hanahmily hanahmily added backend OAP backend related. feature New feature labels Nov 12, 2020
@hanahmily hanahmily added this to the 8.3.0 milestone Nov 12, 2020
@hanahmily
Copy link
Contributor Author

UI screenshot:
WX20201112-172257@2x

@hanahmily hanahmily self-assigned this Nov 12, 2020
@codecov
Copy link

codecov bot commented Nov 12, 2020

Codecov Report

Merging #5835 (1c1144b) into master (ec24c03) will decrease coverage by 9.45%.
The diff coverage is 48.61%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5835      +/-   ##
============================================
- Coverage     51.22%   41.76%   -9.46%     
+ Complexity     3497     2898     -599     
============================================
  Files          1661      902     -759     
  Lines         35659    22527   -13132     
  Branches       3910     2175    -1735     
============================================
- Hits          18266     9409    -8857     
+ Misses        16485    12321    -4164     
+ Partials        908      797     -111     
Impacted Files Coverage Δ Complexity Δ
...meter/analyzer/dsl/ExpressionParsingException.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...e/skywalking/oap/server/receiver/otel/Handler.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../receiver/otel/HandlerInitializationException.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...server/receiver/otel/OtelMetricReceiverConfig.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...server/receiver/otel/OtelMetricReceiverModule.java 66.66% <ø> (ø) 1.00 <0.00> (?)
...g/oap/server/receiver/otel/oc/OCMetricHandler.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...storage/plugin/jdbc/h2/dao/H2MetadataQueryDAO.java 49.34% <0.00%> (ø) 12.00 <0.00> (ø)
...rver/receiver/otel/OtelMetricReceiverProvider.java 16.66% <20.00%> (ø) 3.00 <3.00> (?)
...king/oap/meter/analyzer/prometheus/rule/Rules.java 58.33% <42.85%> (-8.34%) 3.00 <0.00> (ø)
.../skywalking/oap/meter/analyzer/dsl/Expression.java 65.62% <50.00%> (-4.97%) 5.00 <1.00> (ø)
... and 1229 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec24c03...1c1144b. Read the comment docs.

Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
@hanahmily hanahmily marked this pull request as ready for review November 23, 2020 04:08
Co-authored-by: 吴晟 Wu Sheng <wu.sheng@foxmail.com>
@wu-sheng
Copy link
Member

Look like tests fail, please recheck or rerun.

Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
hanahmily and others added 4 commits November 24, 2020 15:19
Co-authored-by: 吴晟 Wu Sheng <wu.sheng@foxmail.com>
Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
@wu-sheng
Copy link
Member

I have feeling whether this PR creating too many metrics to cause the unstable.

@hanahmily
Copy link
Contributor Author

I have feeling whether this PR creating too many metrics to cause the unstable.

Yep, I also fall in with that. How about disabling Istio relevant tables generation in e2e since there is not a single test case for it. That means we don't have a test flow to guarantee whether all of the metrics work together, does it bring and concerns to you?

wu-sheng and others added 4 commits November 25, 2020 08:40
Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wu-sheng wu-sheng merged commit b39c430 into master Nov 25, 2020
@wu-sheng wu-sheng deleted the otel-istio branch November 25, 2020 13:07
@wu-sheng wu-sheng linked an issue Nov 26, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend OAP backend related. feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Istio control panel metrics. OC Analyzer file should be controlled through application.yml
2 participants