Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the timestamp field type for LogQuery #6335

Merged
merged 6 commits into from
Feb 7, 2021
Merged

Conversation

arugal
Copy link
Member

@arugal arugal commented Feb 6, 2021

  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
  • Update the CHANGES log.

image
image

@arugal arugal added bug Something isn't working and you are sure it's a bug! backend OAP backend related. submodule update Change submodule commit ID, including network protocol, query GraphQL and UI labels Feb 6, 2021
@arugal arugal added this to the 8.5.0 milestone Feb 6, 2021
@arugal arugal requested a review from wu-sheng February 6, 2021 16:39
@codecov
Copy link

codecov bot commented Feb 6, 2021

Codecov Report

Merging #6335 (f6e7fa5) into master (3246e1c) will decrease coverage by 4.73%.
The diff coverage is 82.26%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6335      +/-   ##
============================================
- Coverage     53.20%   48.46%   -4.74%     
+ Complexity     3900     3492     -408     
============================================
  Files          1751     1752       +1     
  Lines         37332    37349      +17     
  Branches       4149     4152       +3     
============================================
- Hits          19861    18102    -1759     
- Misses        16489    18264    +1775     
- Partials        982      983       +1     
Impacted Files Coverage Δ Complexity Δ
...server/core/analysis/StreamAnnotationListener.java 72.72% <0.00%> (-7.28%) 7.00 <0.00> (ø)
...ing/oap/server/core/analysis/StreamDefinition.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...oap/server/core/analysis/manual/log/LogRecord.java 63.63% <ø> (ø) 2.00 <0.00> (ø)
...che/skywalking/oap/server/core/query/type/Log.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...age/plugin/elasticsearch/base/NoneStreamEsDAO.java 42.85% <0.00%> (-57.15%) 1.00 <0.00> (-1.00)
.../elasticsearch/cache/NetworkAddressAliasEsDAO.java 76.47% <0.00%> (ø) 3.00 <0.00> (ø)
...ge/plugin/elasticsearch/query/AlarmQueryEsDAO.java 7.40% <0.00%> (ø) 1.00 <0.00> (ø)
...csearch/query/ProfileThreadSnapshotQueryEsDAO.java 4.65% <0.00%> (-89.54%) 1.00 <0.00> (-10.00)
...elasticsearch/query/UITemplateManagementEsDAO.java 6.12% <0.00%> (-65.31%) 2.00 <0.00> (-5.00)
.../plugin/elasticsearch7/query/AlarmQueryEs7DAO.java 7.40% <0.00%> (ø) 1.00 <0.00> (ø)
... and 168 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e8f1eb...f6e7fa5. Read the comment docs.

@wu-sheng
Copy link
Member

wu-sheng commented Feb 7, 2021

And please fix CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend OAP backend related. bug Something isn't working and you are sure it's a bug! submodule update Change submodule commit ID, including network protocol, query GraphQL and UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants